Issue 4210 - Fix dynamic-frame collapsing in Chrome

include.preload.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 108 matching lines @@
 
   for (var i = 0; i < urls.length; i++)
   {
     if (/^(?!https?:)[\w-]+:/i.test(urls[i]))
       urls.splice(i--, 1);
   }
 
   return urls;
 }
 
-function checkCollapse(element)
+function checkCollapse(element, contentDocument)
 {
   window.collapsing = true;
 
   var mediatype = typeMap[element.localName];
   if (!mediatype)
     return;
 
   var urls = getURLsFromElement(element);
   if (urls.length == 0)
     return;
 
-  ext.backgroundPage.sendMessage(
-    {
-      type: "filters.collapse",
-      urls: urls,
-      mediatype: mediatype,
-      baseURL: document.location.href
-    },
+  var message = {
+    type: "filters.collapse",
+    urls: urls,
+    mediatype: mediatype,
+    baseURL: document.location.href
+  };
 
+  if (contentDocument)
+    message.dynamicFrameURL = contentDocument.location.href;
+
+  ext.backgroundPage.sendMessage(message,
     function(collapse)
     {
       function collapseElement()
       {
         if (element.localName == "frame")
           element.style.setProperty("visibility", "hidden", "important");
         else
           element.style.setProperty("display", "none", "important");
       }
 
@@ skipping 387 matching lines @@
           // dynamically created frames. Also on Chrome 37-40
           // document_start content scripts (like this one) don't
           // run either in those frames due to https://crbug.com/416907.
           // So we have to apply element hiding from the parent frame.
           if (!("init" in contentWindow))
             init(contentDocument);
 
           // Moreover, "load" and "error" events aren't dispatched for elements
           // in dynamically created frames due to https://crbug.com/442107.
           // So we also have to apply element collpasing from the parent frame.
           if (!contentWindow.collapsing)

[Sebastian Noack, 2016/08/10 12:38:52]

I'd rather remove this workaround than adding yet another workaround for side
effects of this workaround. Note that we already removed this code path in the
build for Edge to prevent another issue.

The worst that could happen is that some placeholders show up again (if the
Chrome bug still exists). However, at least I cannot reproduce the original
issue (#581) on chip.de anymore if I remove that code (though this might be as
well because they changed their website).

             Array.prototype.forEach.call(
               contentDocument.querySelectorAll(Object.keys(typeMap).join(",")),
-              checkCollapse
+              function(element)
+              {
+                checkCollapse(element, contentDocument);
+              }
             );
         }
       }
     }
   }, true);
 
   return updateStylesheet;
 }
 
 if (document instanceof HTMLDocument)
 {
   checkSitekey();
   window.updateStylesheet = init(document);
 }