Issue #1234 - Remove transitional conversion functions for CString

src/plugin/ATL_Deprecate.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 138 matching lines @@
 
 /*
  * Note:
  *   The preprocessor symbols ATLASSERT and ATLTRACE appear in the source.
  *   These resolve to nothing in Release configurations.
  *   In Debug configurations, these are non-trivial.
  *   ATLASSERT resolves to an expression with _CrtDbgReportW and _CrtDbgBreak.
  *   ATLTRACE resolves to a ATL::CTraceFileAndLineInfo.
  *   These will need to be replaced or removed.
  */
-
-
-/*
- * Transient functions used during the ATL removal process.
- *
- * Trying to convert all the string instances at once leads to massive change sets.
- * In order to be able to convert incrementally, we'll need to undergo a period where we're mixing types.
- * The functions below are explicit conversion functions.
- * While it's possible to convert them by direct calls to member functions,
- *   using explicit conversion functions will allow us to ensure we've removed all the conversions when we're done.
- *
- * These are declared in ATL_Deprecate.h to ensure that they're all removed before we ATL removal is complete.
- *
- * Reference:
- *   MSDN CString http://msdn.microsoft.com/en-us/library/aa300688%28v=vs.60%29.aspx
- */
-
-#include <string>
-/**
- * Conversion function from ATL:CString to std::wstring
- *
- * The argument cannot be declared 'const' because of the CString API.
- * Reference argument usually does not require explicit temporaries.
- */
-std::wstring ToWstring(const ATL::CString& s);
-std::wstring to_wstring(const ATL::CString& s);
-
-/**
- * Conversion function from std::wstring to ATL::CString
- */
-ATL::CString ToCString(const std::wstring& s);
-ATL::CString to_CString(const std::wstring& s);