Issue #1234 - Remove transitional conversion functions for CString

src/plugin/AdblockPlusDomTraverser.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 128 matching lines @@
   if (SUCCEEDED(pEl->get_style(&pStyle)) && pStyle)
   {
     CComBSTR bstrDisplay;
     if (SUCCEEDED(pStyle->get_display(&bstrDisplay)) && ToWstring(bstrDisplay) == L"none")
     {
       return;
     }
     static const CComBSTR sbstrNone(L"none");
     if (SUCCEEDED(pStyle->put_display(sbstrNone)))
     {
-      DEBUG_HIDE_EL(ToWstring(indent) + L"HideEl::Hiding " + ToWstring(type) + L" url:" + url)
+      DEBUG_HIDE_EL(ToWstring(indent) + L"HideEl::Hiding " + type + L" url:" + url)

[RastaJedi, 2016/07/16 19:41:18]

You said you removed last reference to `ToWstring()`? I am probably wrong here
but what about `ToWstring(indent)`?

[RastaJedi, 2016/07/16 19:46:06]

Ignore me!

[Eric, 2016/07/17 14:24:22]

No, this is right.

The macro DEBUG_HIDE_EL is turned off by default, so the compiler doesn't type
check its argument. If it had, it would have shown up. I've been bitten by
exactly this before.

 #ifdef ENABLE_DEBUG_RESULT
         if (isDebug)
         {
           CPluginDebug::DebugResultHiding(type, url, L"-");
         }
 #endif // ENABLE_DEBUG_RESULT
     }
   }
 }