Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include.preload.js

Issue 29349744: Issue 4210 - Remove outdated workaround causing overeager element collapsing (Closed)
Patch Set: Created Aug. 11, 2016, 2:53 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include.preload.js
===================================================================
--- a/include.preload.js
+++ b/include.preload.js
@@ -128,8 +128,6 @@
function checkCollapse(element)
{
- window.collapsing = true;
-
var mediatype = typeMap[element.localName];
if (!mediatype)
return;
@@ -599,15 +597,6 @@
// So we have to apply element hiding from the parent frame.
if (!("init" in contentWindow))
init(contentDocument);
-
- // Moreover, "load" and "error" events aren't dispatched for elements
- // in dynamically created frames due to https://crbug.com/442107.
- // So we also have to apply element collpasing from the parent frame.
- if (!contentWindow.collapsing)
- Array.prototype.forEach.call(
- contentDocument.querySelectorAll(Object.keys(typeMap).join(",")),
- checkCollapse
- );
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld