Noissue - Remove rules which match no resource types

test/abp2blocklist.js

Index: test/abp2blocklist.js
diff --git a/test/abp2blocklist.js b/test/abp2blocklist.js
index fbc4f7d752cae60a9c520c1ff2b886a5b25ebd2a..8f5aa5bca7fd6fa8de14d281622cc21b74230869 100644
--- a/test/abp2blocklist.js
+++ b/test/abp2blocklist.js
@@ -93,6 +93,10 @@ exports.generateRules = {
        action: {type: "block"}}
     ]);
 
+    // Rules which would match no resource-types shouldn't be generated.
+    testRules(test, ["foo$~image,~stylesheet,~script,~font,~media,~object," +
+                     "~xmlhttprequest,~object_subrequest,~ping,~other," +

[Sebastian Noack, 2016/08/20 13:42:50]

It's document as $object-subrequest, with dash, not underscore. 

[kzar, 2016/08/22 12:44:36]

Good point, but since it's kind of a stupid test I instead replaced it with a
more concise one.

+                     "~subdocument", "foo$document"], []);
 
     test.done();
   },
@@ -176,8 +180,8 @@ exports.generateRules = {
       test,
       ["1", "2$image", "3$stylesheet", "4$script", "5$font", "6$media",
        "7$popup", "8$object", "9$object_subrequest", "10$xmlhttprequest",
-       "11$ping", "12$subdocument", "13$other", "14$IMAGE", "15$document",
-       "16$script,PING,Popup", "17$~image"],
+       "11$ping", "12$subdocument", "13$other", "14$IMAGE",
+       "15$script,PING,Popup", "16$~image"],
       [["image", "style-sheet", "script", "font", "media", "raw", "document" ],
        ["image"],
        ["style-sheet"],
@@ -192,7 +196,6 @@ exports.generateRules = {
        ["document"],
        ["raw"],
        ["image"],
-       [],
        ["script", "popup", "raw" ],
        ["style-sheet", "script", "font", "media", "raw", "document"]],
       rules => rules.map(rule => rule.trigger["resource-type"])