Issue 4364 - Drop support for Chrome 29-40 and remove legacy code

chrome/ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 92 matching lines @@
     onActivated: new ext._EventTarget(),
     onRemoved: new ext._EventTarget()
   };
 
   chrome.tabs.onUpdated.addListener(function(tabId, changeInfo, tab)
   {
     if (changeInfo.status == "loading")
       ext.pages.onLoading._dispatch(new Page(tab));
   });
 
   function createFrame(tabId, frameId)

[Sebastian Noack, 2016/09/09 14:39:51]

The changes here are due to rebasing.

[kzar, 2016/09/13 12:30:01]

Acknowledged.

   {
     var frames = framesOfTabs[tabId];
     if (!frames)
       frames = framesOfTabs[tabId] = Object.create(null);
 
     var frame = frames[frameId];
     if (!frame)
       frame = frames[frameId] = {};
 
     return frame;
@@ skipping 352 matching lines @@
             if (parentFrameId != -1)
               frames[details[i].frameId].parent = frames[parentFrameId];
           }
         }
       });
     });
   });
 
   chrome.webRequest.onBeforeRequest.addListener(function(details)
   {
-    // the high-level code isn't interested in requests that aren't
+    // The high-level code isn't interested in requests that aren't
     // related to a tab or requests loading a top-level document,
-    // those should never be blocked
+    // those should never be blocked.
     if (details.tabId == -1 || details.type == "main_frame")
       return;
 
-    // we are looking for the frame that contains the element that
-    // is about to load, however if a frame is loading the surrounding
-    // frame is indicated by parentFrameId instead of frameId
+    // We are looking for the frame that contains the element which
+    // has triggered this request. For most requests (e.g. images) we
+    // can just use the request's frame ID, but for subdocument requests
+    // (e.g. iframes) we must instead use the request's parent frame ID.
     var frameId;
     var requestType;
     if (details.type == "sub_frame")
     {
       frameId = details.parentFrameId;
       requestType = "SUBDOCUMENT";
     }
     else
     {
       frameId = details.frameId;
@@ skipping 121 matching lines @@
   ext.windows = {
     create: function(createData, callback)
     {
       chrome.windows.create(createData, function(createdWindow)
       {
         afterTabLoaded(callback)(createdWindow.tabs[0]);
       });
     }
   };
 })();