Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: test/stub-modules/prefs.js
Issue
29354864
:
Issue 4223 - Migrate some more of adblockplustests (Closed)
Patch Set: Addressed feedback
Created Oct. 4, 2016, 12:04 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Use sandboxed-module
Patch Set 3: Get filterListener tests passing reliably
Patch Set 4: Added filterNotifier tests, improved sourceTransformer logic
Patch Set 5: Migrate filterStorage tests
Patch Set 6: Addressed feedback
Patch Set 7: Moved test/stub-modules/common.js to test/common.js
Patch Set 8: Removed NODE_PATH env variable
Patch Set 9: Allow tests to be run from different directory
Patch Set 10: Fixed typo in test_runner.js
Patch Set 11: Addressed feedback
Patch Set 12: Addressed final nit
Right:
Patch Set 1: None
Patch Set 2: Use sandboxed-module
Patch Set 3: Get filterListener tests passing reliably
Patch Set 4: Added filterNotifier tests, improved sourceTransformer logic
Patch Set 5: Migrate filterStorage tests
Patch Set 6: Addressed feedback
Patch Set 7: Moved test/stub-modules/common.js to test/common.js
Patch Set 8: Removed NODE_PATH env variable
Patch Set 9: Allow tests to be run from different directory
Patch Set 10: Fixed typo in test_runner.js
Patch Set 11: Addressed feedback
Patch Set 12: Addressed final nit
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
package.json
test/_common.js
test/cssRules.js
test/domainRestrictions.js
test/elemHide.js
test/filterClasses.js
test/filterListener.js
test/filterNotifier.js
test/filterStorage.js
test/matcher.js
test/regexpFilters_matching.js
test/signatures.js
test/stub-modules/io.js
test/stub-modules/prefs.js
test/subscriptionClasses.js
test_runner.js
test_wrapper.js
View unified diff
|
Download patch
« no previous file with comments
|
« test/stub-modules/io.js
('k') |
test/subscriptionClasses.js »
('j') |
test_runner.js »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1
exports.Prefs = {};
1
exports.Prefs = {
2
savestats: true
3
};
OLD
NEW
« no previous file with comments
|
« test/stub-modules/io.js
('k') |
test/subscriptionClasses.js »
('j') |
test_runner.js »
('J')
Edit Message
Issue 29354864: Issue 4223 - Migrate some more of adblockplustests (Closed)
Created Sept. 25, 2016, 1:38 p.m. by kzar
Modified Oct. 4, 2016, 12:32 p.m.
Reviewers: Wladimir Palant
Base URL:
Comments: 63
+ 1 drafts
This is Rietveld