Issue 4510 - Filter preferences: replace the built-in findbar widget by our own look-alike

chrome/content/ui/filters.xul

 <?xml version="1.0"?>
 
 <!--
   - This file is part of Adblock Plus <https://adblockplus.org/>,
   - Copyright (C) 2006-2016 Eyeo GmbH
   -
   - Adblock Plus is free software: you can redistribute it and/or modify
   - it under the terms of the GNU General Public License version 3 as
   - published by the Free Software Foundation.
   -
@@ skipping 354 matching lines @@
 
       <treechildren id="filtersTreeChildren"
           oncontextmenu="E('filterActionMenu').openPopupAtScreen(event.screenX, event.screenY, true);"
           tooltip="filtersTooltip"
           noGroupText="&noGroupSelected.text;"
           noFiltersText="&noFiltersInGroup.text;"
           ondragstart="FilterActions.startDrag(event);"
           ondragend="FilterActions.endDrag(event);"/>
     </tree>
 
     <hbox id="findbar" hidden="true" align="center" onkeypress="FilterSearch.keyPress(event);">

[Thomas Greiner, 2016/10/12 14:03:14]

Detail: "hidden" is a boolean attribute so it doesn't have a value. Therefore
valid variants are `hidden="hidden"`, `hidden=""` and `hidden` according to
https://www.w3.org/TR/html-markup/global-attributes.html#common.attrs.hidden.

[Wladimir Palant, 2016/10/12 15:22:00]

This is not HTML ;)

See https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Attribute/hidden

[Thomas Greiner, 2016/10/12 17:18:10]

Unfortunately, the page you mentioned is quite ambiguous about that but I get
your point.

[Wladimir Palant, 2016/10/12 17:53:30]

The text seems to have been imported from XULPlanet.com (© 1999 - 2004) and
never changed - it could definitely use some improvement. The same thing is more
obvious on
https://developer.mozilla.org/en-US/Add-ons/Overlay_Extensions/Firefox_addons...

       <toolbarbutton id="findbar-closebutton" tooltiptext="&findbar.close;" oncommand="FilterSearch.close();"/>
       <textbox id="findbar-textbox" type="search" placeholder="&findbar.placeholder;" flex="1" oncommand="FilterSearch.search();"/>
       <spinbuttons id="findbar-findAgain" onup="FilterSearch.search(-1);" ondown="FilterSearch.search(1);"/>
       <button id="findbar-case-sensitive" type="checkbox" label="&findbar.caseSensitive;" oncommand="FilterSearch.search(0);"/>
       <stack>
-        <label id="findbar-status-wrappedStart" class="findbar-status" value="&findbar.statusWrappedStart;" hidden="true"/>
-        <label id="findbar-status-wrappedEnd" class="findbar-status" value="&findbar.statusWrappedEnd;" hidden="true"/>
-        <label id="findbar-status-notFound" class="findbar-status" value="&findbar.statusNotFound;" hidden="true"/>
+        <label id="findbar-status-wrappedStart" class="findbar-status" value="&findbar.statusWrappedStart;"/>
+        <label id="findbar-status-wrappedEnd" class="findbar-status" value="&findbar.statusWrappedEnd;"/>
+        <label id="findbar-status-notFound" class="findbar-status" value="&findbar.statusNotFound;"/>
       </stack>
     </hbox>
   </vbox>
 </hbox>
 
 <hbox id="buttons">
   <button id="backupButton" type="menu"
       label="&backupButton.label;"
       _backupDialogTitle="&backup.label;" _restoreDialogTitle="&restore.own.label;"
       _fileFilterComplete="&backup.complete.title;" _fileFilterCustom="&backup.custom.title;"
       _backupError="&backup.error;" _restoreError="&restore.error;"
       _restoreCompleteWarning="&restore.complete.warning;" _restoreCustomWarning="&restore.custom.warning;"
       _restoreVersionWarning="&restore.minVersion.warning;"
       oncommand="if (event.target == this) Utils.runAsync(() => this.open = true);">
     <menupopup onpopupshowing="Backup.fillRestorePopup();">
       <menuitem id="backup" key="backup-key" label="&backup.label;…" oncommand="Backup.backupToFile();"/>
       <menuseparator/>
       <menuitem id="restoreBackupTemplate" label="&restore.default.label;" hidden="true"/>
       <menuitem id="restoreOwnBackup" key="restore-key" label="&restore.own.label;…" oncommand="Backup.restoreFromFile();"/>
     </menupopup>
   </button>
 
   <spacer flex="1"/>
 
   <button id="close" dlgtype="accept" label="&close.label;"/>
 </hbox>
 
 </dialog>