Delta Between Two Patch Sets: sitescripts/extensions/utils.py
Issue 29361779:
Issue 4608 - Add local=True To Revision Property (Closed)
Left Patch Set:
Created Nov. 7, 2016, 1:32 p.m.
Right Patch Set: move to local properties
Created Nov. 7, 2016, 1:42 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
no next file »
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 # This file is part of the Adblock Plus web scripts, | 1 # This file is part of the Adblock Plus web scripts, |
| 2 # Copyright (C) 2006-2016 Eyeo GmbH | 2 # Copyright (C) 2006-2016 Eyeo GmbH |
| 3 # | 3 # |
| 4 # Adblock Plus is free software: you can redistribute it and/or modify | 4 # Adblock Plus is free software: you can redistribute it and/or modify |
| 5 # it under the terms of the GNU General Public License version 3 as | 5 # it under the terms of the GNU General Public License version 3 as |
| 6 # published by the Free Software Foundation. | 6 # published by the Free Software Foundation. |
| 7 # | 7 # |
| 8 # Adblock Plus is distributed in the hope that it will be useful, | 8 # Adblock Plus is distributed in the hope that it will be useful, |
| 9 # but WITHOUT ANY WARRANTY; without even the implied warranty of | 9 # but WITHOUT ANY WARRANTY; without even the implied warranty of |
| 10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | 10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| (...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 135 repository = None | 135 repository = None |
| 136 | 136 |
| 137 spiderMonkeyBinary = _defineProperty('spiderMonkeyBinary', default='') | 137 spiderMonkeyBinary = _defineProperty('spiderMonkeyBinary', default='') |
| 138 nightliesDirectory = _defineProperty('nightliesDirectory') | 138 nightliesDirectory = _defineProperty('nightliesDirectory') |
| 139 nightliesURL = _defineProperty('nightliesURL') | 139 nightliesURL = _defineProperty('nightliesURL') |
| 140 downloadsRepo = _defineProperty('downloadsRepo') | 140 downloadsRepo = _defineProperty('downloadsRepo') |
| 141 downloadsURL = _defineProperty('downloadsURL') | 141 downloadsURL = _defineProperty('downloadsURL') |
| 142 docsDirectory = _defineProperty('docsDirectory') | 142 docsDirectory = _defineProperty('docsDirectory') |
| 143 signtool = _defineProperty('signtool') | 143 signtool = _defineProperty('signtool') |
| 144 certname = _defineProperty('signtool_certname') | 144 certname = _defineProperty('signtool_certname') |
| 145 revision = _defineProperty('revision', local=True, default='master') | |
|
Wladimir Palant
2016/11/07 13:33:25
Why did you put it in the middle of global propert
Jon Sonesen
2016/11/07 13:42:25
Acknowledged.
| |
| 146 dbdir = _defineProperty('signtool_dbdir') | 145 dbdir = _defineProperty('signtool_dbdir') |
| 147 dbpass = _defineProperty('signtool_dbpass') | 146 dbpass = _defineProperty('signtool_dbpass') |
| 148 | 147 |
| 149 keyFile = _defineProperty('key', local=True, default='') | 148 keyFile = _defineProperty('key', local=True, default='') |
| 150 name = _defineProperty('name', local=True) | 149 name = _defineProperty('name', local=True) |
| 151 galleryID = _defineProperty('galleryID', local=True, default='') | 150 galleryID = _defineProperty('galleryID', local=True, default='') |
| 152 devbuildGalleryID = _defineProperty('devbuildGalleryID', local=True, default ='') | 151 devbuildGalleryID = _defineProperty('devbuildGalleryID', local=True, default ='') |
| 153 downloadPage = _defineProperty('downloadPage', local=True, default='') | 152 downloadPage = _defineProperty('downloadPage', local=True, default='') |
| 154 clientID = _defineProperty('clientID', local=True, default='') | 153 clientID = _defineProperty('clientID', local=True, default='') |
| 155 clientSecret = _defineProperty('clientSecret', local=True, default='') | 154 clientSecret = _defineProperty('clientSecret', local=True, default='') |
| 156 refreshToken = _defineProperty('refreshToken', local=True, default='') | 155 refreshToken = _defineProperty('refreshToken', local=True, default='') |
| 156 revision = _defineProperty('revision', local=True, default='master') | |
| 157 | 157 |
| 158 latestRevision = _defineNightlyProperty('latestRevision') | 158 latestRevision = _defineNightlyProperty('latestRevision') |
| 159 | 159 |
| 160 def __init__(self, config, nightlyConfig, repositoryName, repository): | 160 def __init__(self, config, nightlyConfig, repositoryName, repository): |
| 161 """ | 161 """ |
| 162 Creates a new Configuration instance that is bound to a particular | 162 Creates a new Configuration instance that is bound to a particular |
| 163 repository. | 163 repository. |
| 164 """ | 164 """ |
| 165 | 165 |
| 166 self.repositoryName = repositoryName | 166 self.repositoryName = repositoryName |
| (...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 375 if not extensions: | 375 if not extensions: |
| 376 return | 376 return |
| 377 | 377 |
| 378 updates = {} | 378 updates = {} |
| 379 for extension in extensions: | 379 for extension in extensions: |
| 380 updates[extension['basename']] = { | 380 updates[extension['basename']] = { |
| 381 'url': extension['updateURL'], | 381 'url': extension['updateURL'], |
| 382 'version': extension['version'] | 382 'version': extension['version'] |
| 383 } | 383 } |
| 384 writeLibabpUpdateManifest(path, updates) | 384 writeLibabpUpdateManifest(path, updates) |
| LEFT | RIGHT |
« no previous file
|
no next file »
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
