Issue 2879 - Move element selection into the content process

lib/windowWrapper.js

Index: lib/windowWrapper.js
===================================================================
--- a/lib/windowWrapper.js
+++ b/lib/windowWrapper.js
@@ -75,25 +75,22 @@ WindowWrapper.prototype =
   popupShowingHandler: function(event)
   {
     let popup = event.originalTarget;
     if (!/^(abp-(?:toolbar|status|menuitem)-)popup$/.test(popup.id))
       return;
 
     this.popupHiddenHandler(event);
 
-    let enabled = Aardvark.canSelect(this.browser);
-    let running = (enabled && this.browser == Aardvark.browser);
+    let running = this.browser == Aardvark.browser;
 
     let [labelStart, labelStop] = getMenuItem();
     let item = popup.ownerDocument.createElement("menuitem");
     item.setAttribute("label", running ? labelStop : labelStart);
     item.setAttribute("class", "elemhidehelper-item");
-    if (!enabled)
-      item.setAttribute("disabled", "true");

[Wladimir Palant, 2016/11/17 13:54:48]

The menu item used to indicate if Element Hiding Helper wouldn't run on some
page. Now that canSelect moved to the child process this got somewhat more
complicated and removed that indicator for now. I think that I will need to
bring it back - show the menu as enabled initially, and set "disabled" attribute
after receiving a response from child.

[saroyanm, 2016/11/23 17:44:39]

Acknowledged.

 
     if (typeof key == "undefined")
       this.configureKey(event.currentTarget);
     item.setAttribute("acceltext", KeySelector.getTextForKey(key));
 
     item.addEventListener("command", this.toggleSelection, false);
 
     let insertBefore = null;
@@ -137,11 +134,11 @@ WindowWrapper.prototype =
       Aardvark.hideTooltips();
   },
 
   toggleSelection: function()
   {
     if ("@adblockplus.org/abp/public;1" in Cc && this.browser != Aardvark.browser)
       Aardvark.start(this);
     else
-      Aardvark.quit();
+      Aardvark.doCommand("quit", null);
   }
 };