Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: packagerChrome.py

Issue 29365583: Issue 4670 - Add a new build type for Gecko-based WebExtensions (Closed) Base URL: https://hg.adblockplus.org/buildtools
Patch Set: Addressed comments Created Dec. 1, 2016, 9:38 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: packagerChrome.py
===================================================================
--- a/packagerChrome.py
+++ b/packagerChrome.py
@@ -330,17 +330,21 @@ def writePackage(outputFile, pubkey, sig
file.write(zipdata)
def createBuild(baseDir, type='chrome', outFile=None, buildNum=None, releaseBuild=False, keyFile=None, devenv=False):
metadata = readMetadata(baseDir, type)
version = getBuildVersion(baseDir, metadata, releaseBuild, buildNum)
if outFile == None:
- outFile = getDefaultFileName(metadata, version, 'crx' if keyFile else 'zip')
+ if type == 'gecko-webext':
+ file_extension = 'xpi'
+ else:
+ file_extension = 'crx' if keyFile else 'zip'
+ outFile = getDefaultFileName(metadata, version, file_extension)
params = {
'type': type,
'baseDir': baseDir,
'releaseBuild': releaseBuild,
'version': version,
'devenv': devenv,
'metadata': metadata,
« no previous file with comments | « build.py ('k') | templates/chromeInfo.js.tmpl » ('j') | templates/chromeInfo.js.tmpl » ('J')

Powered by Google App Engine
This is Rietveld