Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: .hgignore
Issue
29365771
:
Issue 4673 - Add a WebExtensions build configuration (Closed)
Base URL: https://hg.adblockplus.org/adblockpluschrome
Patch Set: Removed pop-up blocking module, relevant platform functionality is unimplemented in Firefox
Created Nov. 30, 2016, 2:17 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Removed pop-up blocking module, relevant platform functionality is unimplemented in Firefox
Patch Set 3: Updated dependency
Right:
Patch Set 1: None
Patch Set 2: Removed pop-up blocking module, relevant platform functionality is unimplemented in Firefox
Patch Set 3: Updated dependency
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.gitignore
.hgignore
dependencies
metadata.gecko-webext
View unified diff
|
Download patch
« no previous file with comments
|
« .gitignore
('k') |
dependencies »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 ^devenv.*$
1 ^devenv.*$
2
2
3 syntax:glob
3 syntax:glob
4 *.zip
4 *.zip
5 *.crx
5 *.crx
6
*.xpi
6 *.pyc
7 *.pyc
7 *.pyo
8 *.pyo
8 *.sh
9 *.sh
OLD
NEW
« no previous file with comments
|
« .gitignore
('k') |
dependencies »
('j') |
no next file with comments »
Edit Message
Issue 29365771: Issue 4673 - Add a WebExtensions build configuration (Closed)
Created Nov. 30, 2016, 10:28 a.m. by Wladimir Palant
Modified Dec. 3, 2016, 9:31 p.m.
Reviewers kzar
Base URL: https://hg.adblockplus.org/adblockpluschrome
Comments: 3
This is Rietveld