metadata.edge - Issue 29365879: Issue 4616 - Push Edge related changes to the edge bookmark of adblockpluschrome

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: metadata.edge

Issue 29365879: Issue 4616 - Push Edge related changes to the edge bookmark of adblockpluschrome (Closed)

Left Patch Set: Adapt the README.md Created Dec. 19, 2016, 11:42 a.m.

Right Patch Set: Hardcode the version number for Edge Created Dec. 19, 2016, 2:46 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [default]	1 [default]

2 inherit = metadata.chrome	2 inherit = metadata.chrome

3	3

4 [general]	4 [general]
Sebastian Noack 2016/12/19 11:48:34 As long as Adblock Plus is still in beta, and stil As long as Adblock Plus is still in beta, and still not released out of upstream, the version should remain 0.9.. So we have to override the "version" key in the "general" section. Oleksandr* 2016/12/19 12:41:33 Our current version is 0.9.9.9. What would you see Show quoted text On 2016/12/19 11:48:34, Sebastian Noack wrote: > As long as Adblock Plus is still in beta, and still not released out of > upstream, the version should remain 0.9.. So we have to override the "version" > key in the "general" section. Our current version is 0.9.9.9. What would you see the next version to be? Besides, the version built from this will* be based on the upstream, so I think it's a good time to switch to the correct version number now. Sebastian Noack 2016/12/19 14:28:05 Our current version is 0.9.9.0 (not 0.9.9.9), and Show quoted text On 2016/12/19 12:41:33, Oleksandr wrote: > On 2016/12/19 11:48:34, Sebastian Noack wrote: > > As long as Adblock Plus is still in beta, and still not released out of > > upstream, the version should remain 0.9.. So we have to override the > "version" > > key in the "general" section. > Our current version is 0.9.9.9. What would you see the next version to be? > Besides, the version built from this will* be based on the upstream, so I think > it's a good time to switch to the correct version number now. Our current version is 0.9.9.0 (not 0.9.9.9), and the next version would be 0.9.10. As far as version numbers matter in the first place, the 0.* notation is _correct_ and important to indicate that we are in beta, which isn't going to change before we merged the branch upstream and before we get the storage logic straight which then again requires the Windows Creators Update. Moreover, we might introduce conflicts when the upstream branch (i.e. tip) and the edge branch are on the same version track but are released separately.
	5 version = 0.9.10.0

5 basename = adblockplusedge	6 basename = adblockplusedge

6 app_id = EyeoGmbH.AdblockPlus	7 app_id = EyeoGmbH.AdblockPlus

7 publisher_id = CN=4F066043-8AFE-41C9-B762-6C15E77E3F88	8 publisher_id = CN=4F066043-8AFE-41C9-B762-6C15E77E3F88

8 background_color = red	9 background_color = red

9	10

10 [compat]	11 [compat]

11 edge = 37.14332.1000.0	12 edge = 37.14332.1000.0

12 windows = 10.0.14332.0/12.0.0.0	13 windows = 10.0.14332.0/12.0.0.0

13	14

14 [appx_assets]	15 [appx_assets]

15 logo_44.png = icons/abp-44.png	16 logo_44.png = icons/abp-44.png

16 logo_50.png = icons/abp-50.png	17 logo_50.png = icons/abp-50.png

17 logo_150.png = icons/abp-150.png	18 logo_150.png = icons/abp-150.png

LEFT	RIGHT