Issue 4657 - Add Acceptable Ads API

test/FilterEngine.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 891 matching lines @@
       {
         // no subscription (because of preconfigured prefs.json and patterns.ini),
         // though it should be enabled by default in a non-test environment, it's tested in
         // corresponding tests.
         const auto subscriptions = filterEngine->GetListedSubscriptions();
         EXPECT_EQ(0u, subscriptions.size()); // no any subscription including AA
         EXPECT_FALSE(filterEngine->IsAAEnabled());
       }
       if (otherSubscriptionsNumber == 1u)
       {
-        auto subscruption = filterEngine->GetSubscription(kOtherSubscriptionUrl);

[hub, 2017/04/05 14:52:47]

'nit: I didn't see that one. There is a typo. It is "subscription"

And below, since this compiles.

[sergei, 2017/04/05 16:54:45]

Done. Good catch.

-        ASSERT_TRUE(subscruption);
-        subscruption->AddToList();
+        auto subscription = filterEngine->GetSubscription(kOtherSubscriptionUrl);
+        ASSERT_TRUE(subscription);
+        subscription->AddToList();
         const auto subscriptions = filterEngine->GetListedSubscriptions();
         ASSERT_EQ(1u, subscriptions.size());
         EXPECT_FALSE(subscriptions[0]->IsAA());
         EXPECT_EQ(kOtherSubscriptionUrl, subscriptions[0]->GetProperty("url")->AsString());
       }
       if (isAASatusPresent(aaStatus))
       {
         filterEngine->SetAAEnabled(true); // add AA by enabling it
         if (aaStatus == AAStatus::disabled_present)
         {
@@ skipping 161 matching lines @@
     filterEngine->SetAllowedConnectionType(&testConnection);
     auto subscription = EnsureExampleSubscriptionAndForceUpdate("subB");
     EXPECT_EQ("synchronize_ok", subscription->GetProperty("downloadStatus")->AsString());
     EXPECT_EQ(1u, subscription->GetProperty("filters")->AsList().size());
     auto capturedConnectionTypes = this->capturedConnectionTypes.GetStrings();
     ASSERT_EQ(1u, capturedConnectionTypes.size());
     EXPECT_TRUE(capturedConnectionTypes[0].first);
     EXPECT_EQ(testConnection, capturedConnectionTypes[0].second);
   }
 }