Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: lib/filterComposer.js

Issue 29366990: Issue 4714 - "Block element" context menu item fails to open window (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome
Patch Set: Created Dec. 7, 2016, 12:56 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 port.on("composer.openDialog", (message, sender) => 192 port.on("composer.openDialog", (message, sender) =>
193 { 193 {
194 return new Promise(resolve => 194 return new Promise(resolve =>
195 { 195 {
196 ext.windows.create({ 196 ext.windows.create({
197 url: ext.getURL("composer.html"), 197 url: ext.getURL("composer.html"),
198 left: 50, 198 left: 50,
199 top: 50, 199 top: 50,
200 width: 420, 200 width: 420,
201 height: 200, 201 height: 200,
202 focused: true,
203 type: "popup" 202 type: "popup"
204 }, 203 },
205 popupPage => 204 popupPage =>
206 { 205 {
207 let popupPageId = popupPage.id; 206 let popupPageId = popupPage.id;
208 function onRemoved(removedPageId) 207 function onRemoved(removedPageId)
209 { 208 {
210 if (popupPageId == removedPageId) 209 if (popupPageId == removedPageId)
211 { 210 {
212 sender.page.sendMessage({ 211 sender.page.sendMessage({
(...skipping 22 matching lines...) Expand all
235 baseURL: message.baseURL, 234 baseURL: message.baseURL,
236 page: sender.page, 235 page: sender.page,
237 frame: sender.frame 236 frame: sender.frame
238 }); 237 });
239 }); 238 });
240 239
241 ext.pages.onLoading.addListener(page => 240 ext.pages.onLoading.addListener(page =>
242 { 241 {
243 page.sendMessage({type: "composer.content.finished"}); 242 page.sendMessage({type: "composer.content.finished"});
244 }); 243 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld