Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: test/filterClasses.js

Issue 29367031: Issue 4684 - Allow { and } in attribute and property selectors (Closed) Base URL: https://bitbucket.org/fhd/adblockpluscore
Left Patch Set: Created Dec. 8, 2016, 10:10 a.m.
Right Patch Set: Add a space after the escape sequence for { and } Created Dec. 13, 2016, 4:01 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « lib/filterClasses.js ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 362 matching lines...) Expand 10 before | Expand all | Expand 10 after
373 for (let filterText of emptyDomainFilters) 373 for (let filterText of emptyDomainFilters)
374 { 374 {
375 let filter = Filter.fromText(filterText); 375 let filter = Filter.fromText(filterText);
376 test.ok(filter instanceof InvalidFilter); 376 test.ok(filter instanceof InvalidFilter);
377 test.equal(filter.reason, "filter_invalid_domain"); 377 test.equal(filter.reason, "filter_invalid_domain");
378 } 378 }
379 379
380 test.done(); 380 test.done();
381 }; 381 };
382 382
383 exports.testCssRuleInjection = function(test) 383 exports.testElemHideRulesWithBraces = function(test)
384 { 384 {
385 compareFilter(test, "###foo{color: red}", 385 compareFilter(test, "###foo{color: red}",
386 ["type=filterlist", 386 ["type=elemhide",
387 "text=###foo{color: red}", 387 "text=###foo{color: red}",
388 "regexp=\\#\\#\\#foo\\{color\\:\\ red\\}"]); 388 "selectorDomain=",
389 "selector=#foo\\x7B color: red\\x7D ",
390 "domains="]);
389 compareFilter(test, "foo.com##[-abp-properties='/margin: [3-4]{2}/']", 391 compareFilter(test, "foo.com##[-abp-properties='/margin: [3-4]{2}/']",
390 ["type=elemhideemulation", 392 ["type=elemhideemulation",
391 "text=foo.com##[-abp-properties='/margin: [3-4]{2}/']", 393 "text=foo.com##[-abp-properties='/margin: [3-4]{2}/']",
392 "selectorDomain=foo.com", 394 "selectorDomain=foo.com",
393 "selector=[-abp-properties='/margin: [3-4]{2}/']", 395 "selector=[-abp-properties='/margin: [3-4]\\x7B 2\\x7D /']",
394 "domains=FOO.COM"]); 396 "domains=FOO.COM"]);
395 compareFilter(test, "foo.com##[foo~='{bar}']", 397 test.done();
396 ["type=elemhide", 398 };
397 "text=foo.com##[foo~='{bar}']",
398 "selectorDomain=foo.com",
399 "selector=[foo~='{bar}']",
400 "domains=FOO.COM"]);
401 compareFilter(test, "foo.com##''{color: red}''",
402 ["type=filterlist",
403 "text=foo.com##''{color: red}''",
404 "regexp=foo\\.com\\#\\#\\'\\'\\{color\\:\\ red\\}\\'\\'"]);
405 compareFilter(test, "foo.com##[foo='']{color: red}[foo='']",
406 ["type=filterlist",
407 "text=foo.com##[foo='']{color: red}[foo='']",
408 "regexp=foo\\.com\\#\\#\\[foo\\=\\'\\'\\]\\{color\\:\\ red\\}\\ [foo\\=\\'\\'\\]"]);
409 test.done();
410 };
LEFTRIGHT

Powered by Google App Engine
This is Rietveld