chrome/content/elemHideEmulation.js - Issue 29367181: Issue 4726 - Add tests for the element hiding emulation content script

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: chrome/content/elemHideEmulation.js

Issue 29367181: Issue 4726 - Add tests for the element hiding emulation content script (Closed) Base URL: https://bitbucket.org/fhd/adblockpluscore

Patch Set: Addressed remaining comments Created Jan. 17, 2017, 7:39 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/content/elemHideEmulation.js

===================================================================

--- a/chrome/content/elemHideEmulation.js

+++ b/chrome/content/elemHideEmulation.js

@@ -1,8 +1,11 @@

+// We are currently limited to ECMAScript 5 in this file, because it is being

kzar 2017/01/18 04:17:15 Perhaps mentioning PhantomJS and the version in th

Felix Dahlke 2017/01/19 09:56:51 The information is in the issue, I'd personally ra

+// used in the browser tests. See https://issues.adblockplus.org/ticket/4796

var propertySelectorRegExp = /\[\-abp\-properties=(["'])([^"']+)\1\]/;

function splitSelector(selector)

{

if (selector.indexOf(",") == -1)

return [selector];

var selectors = [];

« no previous file with comments | « README.md ('k') | lib/common.js » ('j') | test/browser/elemHideEmulation.js » ('J')