Unified Diff: lib/requestBlocker.js
Issue 29367316:
Issue 4722 - Drop support for Chrome 41 - 48 (Closed)
Patch Set: Removed getIndistinguishableTypes function
Created Dec. 16, 2016, 9:37 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« lib/polyfills/fetch.js ('k')
|
metadata.chrome » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: lib/requestBlocker.js |
| diff --git a/lib/requestBlocker.js b/lib/requestBlocker.js |
| index 0b3291a332dd1e949285dc8a532df0d09ea96302..64b8856998cfb740f3d04f5dd6caa0ae40f7bfb3 100644 |
| --- a/lib/requestBlocker.js |
| +++ b/lib/requestBlocker.js |
| @@ -29,11 +29,8 @@ let {stringifyURL, extractHostFromFrame, isThirdParty} = require("url"); |
| let {port} = require("messaging"); |
| let devtools = require("devtools"); |
| -ext.webRequest.getIndistinguishableTypes().forEach(types => |
| -{ |
| - for (let i = 1; i < types.length; i++) |
| - RegExpFilter.typeMap[types[i]] = RegExpFilter.typeMap[types[0]]; |
| -}); |
| +// Chrome can not distinguish between OBJECT_SUBREQUEST and OBJECT requests. |
|
Wladimir Palant
2016/12/16 10:06:15
Nit: I learned that it is "cannot" in English ;)
kzar
2016/12/16 10:27:34
Heh good point, well even better I went for "can't
|
| +RegExpFilter.typeMap.OBJECT_SUBREQUEST = RegExpFilter.typeMap.OBJECT; |
| function onBeforeRequestAsync(page, url, type, docDomain, |
| thirdParty, sitekey, |
« no previous file with comments
|
« lib/polyfills/fetch.js ('k')
|
metadata.chrome » ('j')
|
no next file with comments »
