metadata.edge - Issue 29367480: Issue 4721 - Use IndexedDB for storage in Edge

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: metadata.edge

Issue 29367480: Issue 4721 - Use IndexedDB for storage in Edge (Closed)

Left Patch Set: Created Dec. 14, 2016, 1:48 a.m.

Right Patch Set: Address some nits Created Dec. 20, 2016, 2:31 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [default]	1 [default]

2 inherit = metadata.chrome	2 inherit = metadata.chrome

3	3

4 [general]	4 [general]

	5 version = 0.9.10.0

5 basename = adblockplusedge	6 basename = adblockplusedge

6 app_id = EyeoGmbH.AdblockPlus	7 app_id = EyeoGmbH.AdblockPlus

7 publisher_id = CN=4F066043-8AFE-41C9-B762-6C15E77E3F88	8 publisher_id = CN=4F066043-8AFE-41C9-B762-6C15E77E3F88

8 background_color = red	9 background_color = red

9 backgroundScripts = lib/polyfills/fetch.js	10 backgroundScripts = lib/polyfills/fetch.js
kzar 2016/12/16 13:22:25 FYI: This just got removed from master, watch out FYI: This just got removed from master, watch out if you rebase again. Oleksandr 2016/12/19 11:03:15 Acknowledged. Show quoted text On 2016/12/16 13:22:25, kzar wrote: > FYI: This just got removed from master, watch out if you rebase again. Acknowledged.	Sebastian Noack 2017/01/11 15:17:23 Is it necessary to duplicate all scripts here? Can Is it necessary to duplicate all scripts here? Can't you just do it like that: backgroundScripts += lib/localforage.min.js Oleksandr 2017/01/11 15:29:46 The order is important here. localforage has to be Show quoted text On 2017/01/11 15:17:23, Sebastian Noack wrote: > Is it necessary to duplicate all scripts here? Can't you just do it like that: > > backgroundScripts += lib/localforage.min.js The order is important here. localforage has to be included before adblockplus.js, for example.
10 lib/localforage.min.js	11 lib/localforage.min.js

11 ext/common.js	12 ext/common.js

12 ext/background.js	13 ext/background.js

13 lib/compat.js	14 lib/compat.js

14 lib/info.js	15 lib/info.js

15 lib/publicSuffixList.js	16 lib/publicSuffixList.js

16 lib/adblockplus.js	17 lib/adblockplus.js

17 messageResponder.js	18 messageResponder.js

18 background.js	19 background.js

19	20

20 [compat]	21 [compat]

21 edge = 37.14332.1000.0	22 edge = 37.14332.1000.0

22 windows = 10.0.14332.0/12.0.0.0	23 windows = 10.0.14332.0/12.0.0.0

23	24

24 [appx_assets]	25 [appx_assets]

25 logo_44.png = icons/abp-44.png	26 logo_44.png = icons/abp-44.png

26 logo_50.png = icons/abp-50.png	27 logo_50.png = icons/abp-50.png

27 logo_150.png = icons/abp-150.png	28 logo_150.png = icons/abp-150.png

LEFT	RIGHT