[adblockpluschrome] Issue 4764 - Added "relentless" notification that shows up in intervals

lib/notificationHelper.js

Index: lib/notificationHelper.js
diff --git a/lib/notificationHelper.js b/lib/notificationHelper.js
index 385614a351d505b1f665d9eb42ad484d47585f74..8ed75f8751f3c1db5007eebe4ff58e8cb81bf6c2 100644
--- a/lib/notificationHelper.js
+++ b/lib/notificationHelper.js
@@ -30,6 +30,7 @@ let displayMethods = Object.create(null);
 displayMethods.critical = ["icon", "notification", "popup"];
 displayMethods.question = ["notification"];
 displayMethods.normal = ["notification"];
+displayMethods.relentless = ["notification"];
 displayMethods.information = ["icon", "popup"];
 
 // Chrome on Linux does not fully support chrome.notifications until version 35
@@ -98,7 +99,7 @@ function getNotificationButtons(notificationType, message)
         }
       ];
     }
-    if (notificationType != "critical")
+    if (["critical", "relentless"].indexOf(notificationType) == -1)

[Sebastian Noack, 2017/01/05 12:46:11]

Using indexOf() for membership checks seems unnecessary here. The following
seems much easier to read to me (and is also faster if it would matter):

 if (notificationType != "critical" && notificationType != "relentless")
   ...

Also note that arrays also have an includes() method which would still be better
than using indexOf(). Or you could use a Set and it's has() method, which would
be most appropriate if you have a container that you only use for membership
checks. Though for simplicity, I'd prefer to use simple comparision logic here,
as indicated above.

[wspee, 2017/01/05 15:19:27]

Done.

     {
       buttons.push({
         type: "configure",
@@ -238,6 +239,9 @@ function showNotification(notification)
     }
   }
   prepareNotificationIconAndPopup();
+
+  if (notification.type !== "question")

[Sebastian Noack, 2017/01/05 12:46:11]

As per the Mozilla coding style guide
(https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style...)
which is referenced in our coding style guide
(https://adblockplus.org/coding-style#javascript), we prefer != over !==.

[wspee, 2017/01/05 15:19:27]

Done.

+    NotificationStorage.markAsShown(notification.id);
 };
 
 /**