tests/test_site/pages/sitemap.tmpl - Issue 29370597: Issue 4687 - Add Context Function get_pages_metadata to Test Site

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: tests/test_site/pages/sitemap.tmpl

Issue 29370597: Issue 4687 - Add Context Function get_pages_metadata to Test Site (Closed)

Patch Set: Created Jan. 2, 2017, 9:30 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 template = empty

	2 product = foo

	3 title = test_metadata

	4 tags = popular, bar

	5 <h1> Unfiltered </h1>

	6 <ul>

	7 {%- for unfiltered_page in get_pages_metadata() -%}

	8 <li>{{ unfiltered_page }} </li>

	9 {%- endfor %}

	10 </ul>

	11

	12 <h1> Filtered </h1>

	13 <ul>

	14 {%- for page in get_pages_metadata({'tags': 'popular, bar'}) -%}
	Vasily Kuznetsov 2017/01/11 10:52:44 I see you changed the API a little from what is de I see you changed the API a little from what is described in the ticket. The way it is there this call would be: get_pages_metadata({'tags': ['popular', 'bar']}) I don't mind the change, it seems that it actually simplifies both the implementation and the usage. You should probably update the ticket though, to make sure it's all in sync. Jon Sonesen 2017/01/11 17:37:04 Acknowledged. Show quoted text On 2017/01/11 10:52:44, Vasily Kuznetsov wrote: > I see you changed the API a little from what is described in the ticket. The way > it is there this call would be: > > get_pages_metadata({'tags': ['popular', 'bar']}) > > I don't mind the change, it seems that it actually simplifies both the > implementation and the usage. You should probably update the ticket though, to > make sure it's all in sync. Acknowledged.
	15 <li> {{ page }} </li>

	16 {%- endfor %}

	17 </ul>

OLD	NEW