Issue 4767 - Improve error reporting in update_update_manifests

sitescripts/extensions/utils.py

 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2016 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
@@ skipping 305 matching lines @@
     object
     """
     for repo in Configuration.getRepositoryConfigurations():
         try:
             (downloadURL, version) = _getDownloadLink(repo)
             if downloadURL is None:
                 raise Exception('No download link found for repo: ' +
                                 repo.repositoryName)
         except ExpatError:
             traceback.print_exc()
-            print "Error found while parsing xml from %s link" % repo.repositoryName
+            print 'Error found while parsing xml from {0} link'\

[Vasily Kuznetsov, 2017/01/09 21:59:54]

Breaking lines with a backslash (`\`) is generally not recommended. It's
preferrable to do something like this:

print ('bla bla {0}'
       .format(arg))

Also previous line prints to stderr and this print will print to stderr. Is this
intended or should we print to stderr here as well?

[Vasily Kuznetsov, 2017/01/09 22:01:12]

Sorry, I meant that this print statement will print to stdout (while we probably
want stderr).

+                .format(repo.repositoryName)
             continue
         except:
             traceback.print_exc()
             continue
         if not result.has_section(repo.repositoryName):
             result.add_section(repo.repositoryName)
         result.set(repo.repositoryName, 'downloadURL', downloadURL)
         result.set(repo.repositoryName, 'version', version)
 
         qrcode = _getQRCode(downloadURL)
@@ skipping 47 matching lines @@
     if not extensions:
         return
 
     updates = {}
     for extension in extensions:
         updates[extension['basename']] = {
             'url': extension['updateURL'],
             'version': extension['version']
         }
     writeLibabpUpdateManifest(path, updates)