Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: sitescripts/extensions/utils.py

Issue 29370859: Issue 4767 - Improve error reporting in update_update_manifests (Closed)
Patch Set: For comments 7 and 8 by vasily Created Jan. 9, 2017, 10:38 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sitescripts/extensions/utils.py
===================================================================
--- a/sitescripts/extensions/utils.py
+++ b/sitescripts/extensions/utils.py
@@ -23,9 +23,11 @@
import urlparse
import urllib
import xml.dom.minidom as dom
+import sys
from ConfigParser import SafeConfigParser, NoOptionError
from StringIO import StringIO
from sitescripts.utils import get_config
+from xml.parsers.expat import ExpatError
PACKAGE_SUFFIXES = {
'gecko': '.xpi',
@@ -320,6 +322,11 @@
if downloadURL is None:
raise Exception('No download link found for repo: ' +
repo.repositoryName)
+ except ExpatError:
+ traceback.print_exc()
+ print >> sys.stderr, ('Error found while parsing xml from {0} link'
+ .format(repo.repositoryName))
+ continue
except:
traceback.print_exc()
continue
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld