Issue 4722 - Remove old check for Chrome notification API

lib/notificationHelper.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 15 matching lines @@
 
 let activeNotification = null;
 let activeButtons = null;
 let defaultDisplayMethods = ["popup"];
 let displayMethods = Object.create(null);
 displayMethods.critical = ["icon", "notification", "popup"];
 displayMethods.question = ["notification"];
 displayMethods.normal = ["notification"];
 displayMethods.information = ["icon", "popup"];
 
-// Chrome on Linux does not fully support chrome.notifications until version 35
-// https://code.google.com/p/chromium/issues/detail?id=291485
-let canUseChromeNotifications = (function()
-{
-  let info = require("info");
-  if (info.platform == "chromium" && "notifications" in chrome)
-  {
-    if (navigator.platform.indexOf("Linux") == -1)
-      return true;
-    if (Services.vc.compare(info.applicationVersion, "35") >= 0)
-      return true;
-  }
-  return false;
-})();
+let platform = require("info").platform;
+let canUseChromeNotifications = platform == "chromium" && "notifications" in chrome;

[Sebastian Noack, 2017/01/13 11:43:23]

Any reason to still check for the platform? This would exclude Firefox and
Microsoft Edge, regardless whether they implement the notifications API.

[kzar, 2017/01/16 04:15:37]

Not really but IMO that change is for when we switch to the browser API, since
`chrome` will be undefined on Edge anyway. I guess I could simply test for the
presence of chrome for now.

[Sebastian Noack, 2017/01/16 13:39:59]

Well, when we switch to the browser.* API we would use browser.notfication
instead of chrome.notifcation here of course. So I don't see any reason to check
for the existence of "chrome" either. Or is there any reason we have to exclude
Edge here regardless whether it has browser.notifcations or not?

[kzar, 2017/01/16 13:50:22]

I guess not, Done.

 
 function prepareNotificationIconAndPopup()
 {
   let animateIcon = shouldDisplay("icon", activeNotification.type);
   activeNotification.onClicked = function()
   {
     if (animateIcon)
       stopIconAnimation();
     notificationClosed();
   };
@@ skipping 215 matching lines @@
   let methods = displayMethods[notificationType] || defaultDisplayMethods;
   return methods.indexOf(method) > -1;
 };
 
 ext.pages.onLoading.addListener(page =>
 {
   NotificationStorage.showNext(stringifyURL(page.url));
 });
 
 NotificationStorage.addShowListener(showNotification);