Issue 4795 - Use modern JavaScript syntax

chrome/ext/common.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-(function()

[Sebastian Noack, 2017/01/13 12:30:50]

As mentioned on the other review, unless you use strict mode, named functions
are still defined globally without IFEE. There are no named functions in this
file, but while on it, why not just add "use strict" everywhere as well? This is
arguably any more risky than the changes you are doing here anyway. And that way
we don't potentially export any named functions (in the future), plus we benefit
from other advantages of strict mode.

[kzar, 2017/01/16 04:09:11]

Done.

 {
   /* Message passing */
 
   ext.onMessage = new ext._EventTarget();
 
 
   /* Background page */
 
   ext.backgroundPage = {
     sendMessage: chrome.runtime.sendMessage,
-    getWindow: function()
-    {
-      return chrome.extension.getBackgroundPage();
-    }
+    getWindow: () => chrome.extension.getBackgroundPage()

[Sebastian Noack, 2017/01/13 12:30:50]

I think for method definitions, the method definition shorthand syntax is
preferable over arrow functions:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/M...

The only question is whether it is supported by Microsoft Edge, yet?

[kzar, 2017/01/16 04:09:11]

According to this page[1] they are. Also I just tested them in Edge 38 myself
and they seem to work OK. Done.

[1] - http://kangax.github.io/compat-table/es5/

   };
 
 
   /* Utils */
 
   ext.getURL = chrome.extension.getURL;
   ext.i18n = chrome.i18n;
-})();
+}