Issue 4795 - Use modern JavaScript syntax

chrome/ext/popup.js

-(function()
+"use strict";
+
 {
-  var backgroundPage = chrome.extension.getBackgroundPage();
+  let backgroundPage = chrome.extension.getBackgroundPage();
   window.ext = Object.create(backgroundPage.ext);
 
-  ext.closePopup = function()
+  ext.closePopup = () =>
   {
     window.close();
   };
 
   // We have to override ext.backgroundPage, because in order
   // to send messages the local "chrome" namespace must be used.
   ext.backgroundPage = {
     sendMessage: chrome.runtime.sendMessage,
 
-    getWindow: function()
-    {
-      return backgroundPage;
-    }
+    getWindow() { return backgroundPage; }

[Sebastian Noack, 2017/01/16 15:35:55]

As pointed out in a different file, in the previous review round, these
whitespace changes are unrelated, and are arguably desirable.

[kzar, 2017/01/17 07:42:48]

Whoops, another victim from switching to an inline arrow function and back to
the new method definition syntax. Done.

   };
-})();
+}