Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: qunit/tests/versionComparator.js

Issue 29371763: Issue 4795 - Use modern JavaScript syntax (Closed)
Left Patch Set: Created Jan. 13, 2017, 12:11 p.m.
Right Patch Set: Addressed some more feedback Created Jan. 18, 2017, 11:44 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « qunit/tests/url.js ('k') | stats.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 "use strict";
18 19
19 { 20 {
20 let compare = Services.vc.compare; 21 let compare = Services.vc.compare;
21 22
22 function allPairs(array) 23 function allPairs(array)
23 { 24 {
24 let pairs = []; 25 let pairs = [];
25 for (let i = 0; i < array.length - 1; i++) 26 for (let i = 0; i < array.length - 1; i++)
26 for (let j = i + 1; j < array.length; j++) 27 for (let j = i + 1; j < array.length; j++)
27 pairs.push([array[i], array[j]]); 28 pairs.push([array[i], array[j]]);
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 allPairs(examples).forEach(pair => 99 allPairs(examples).forEach(pair =>
99 { 100 {
100 let v1 = [].concat(pair[0]); 101 let v1 = [].concat(pair[0]);
101 let v2 = [].concat(pair[1]); 102 let v2 = [].concat(pair[1]);
102 for (let i = 0; i < v1.length; i++) 103 for (let i = 0; i < v1.length; i++)
103 for (let j = 0; j < v2.length; j++) 104 for (let j = 0; j < v2.length; j++)
104 versionSmaller(v1[i], v2[j]); 105 versionSmaller(v1[i], v2[j]);
105 }); 106 });
106 }); 107 });
107 } 108 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld