Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: composer.postload.js

Issue 29371763: Issue 4795 - Use modern JavaScript syntax (Closed)
Left Patch Set: Fix scoping regression Created Jan. 16, 2017, 9:12 a.m.
Right Patch Set: Addressed some more feedback Created Jan. 18, 2017, 11:44 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « composer.js ('k') | ext/background.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 176
177 highlightElement(overlay, shadowColor, backgroundColor); 177 highlightElement(overlay, shadowColor, backgroundColor);
178 overlay.style.pointerEvents = "none"; 178 overlay.style.pointerEvents = "none";
179 179
180 element._unhighlight = () => 180 element._unhighlight = () =>
181 { 181 {
182 overlay.parentNode.removeChild(overlay); 182 overlay.parentNode.removeChild(overlay);
183 }; 183 };
184 }; 184 };
185 185
186 let highlightWithStyleAttribute = () => 186 let highlightWithStyleAttribute = () =>
187 { 187 {
188 let originalBoxShadow = element.style.getPropertyValue("box-shadow"); 188 let originalBoxShadow = element.style.getPropertyValue("box-shadow");
189 let originalBoxShadowPriority = 189 let originalBoxShadowPriority =
190 element.style.getPropertyPriority("box-shadow"); 190 element.style.getPropertyPriority("box-shadow");
191 let originalBackgroundColor = 191 let originalBackgroundColor =
192 element.style.getPropertyValue("background-color"); 192 element.style.getPropertyValue("background-color");
193 let originalBackgroundColorPriority = 193 let originalBackgroundColorPriority =
194 element.style.getPropertyPriority("background-color"); 194 element.style.getPropertyPriority("background-color");
195 195
196 element.style.setProperty("box-shadow", "inset 0px 0px 5px " + shadowColor, 196 element.style.setProperty("box-shadow", "inset 0px 0px 5px " + shadowColor,
(...skipping 384 matching lines...) Expand 10 before | Expand all | Expand 10 after
581 } 581 }
582 }); 582 });
583 } 583 }
584 break; 584 break;
585 } 585 }
586 }); 586 });
587 587
588 if (window == window.top) 588 if (window == window.top)
589 ext.backgroundPage.sendMessage({type: "composer.ready"}); 589 ext.backgroundPage.sendMessage({type: "composer.ready"});
590 } 590 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld