Issue 4795 - Use modern JavaScript syntax

notification.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
-const backgroundPage = ext.backgroundPage.getWindow();
-const {require} = backgroundPage;

[Sebastian Noack, 2017/01/18 11:24:28]

Note that backgroundPage isn't used anywhere else, so how about this:

  const {require} = ext.backgroundPage.getWindow();

[kzar, 2017/01/18 11:46:39]

Done.

+const {require} = ext.backgroundPage.getWindow();
 
 const {Utils} = require("utils");
 const {Notification} = require("notification");
 const {getActiveNotification, shouldDisplay} = require("notificationHelper");
 
 function getDocLinks(notification)
 {
   if (!notification.links)
     return [];
 
@@ skipping 68 matching lines @@
         break;
       case "notification-optout":
         Notification.toggleIgnoreCategory("*", true);
       case "notification-hide":
         notificationElement.hidden = true;
         notification.onClicked();
         break;
     }
   }, true);
 }, false);