lib/filterValidation.js - Issue 29371763: Issue 4795 - Use modern JavaScript syntax

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/filterValidation.js

Issue 29371763: Issue 4795 - Use modern JavaScript syntax (Closed)

Patch Set: Workaround limiation with iterating element collections in older versions of Chrome Created Jan. 16, 2017, 8:46 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/filterValidation.js

diff --git a/lib/filterValidation.js b/lib/filterValidation.js

index f5de14b7a75c670802a37fa676a10cb51c51dcd5..9252ac1ca4d81523ce85711b1bef928713842904 100644

--- a/lib/filterValidation.js

+++ b/lib/filterValidation.js

@@ -17,6 +17,8 @@

/** @module filterValidation */

+"use strict";

let {Filter, InvalidFilter, ElemHideBase} = require("filterClasses");

let {Utils} = require("utils");

@@ -63,7 +65,7 @@ FilterParsingError.prototype = {

* @return {string}

- toString: function()

+ toString()

{

let message;

if (this.reason)

@@ -115,7 +117,7 @@ let parseFilter =

* @param {string} text

* @return {ParsedFilter}

-exports.parseFilter = function(text)

+exports.parseFilter = text =>

{

let filter = null;

text = Filter.normalize(text);

@@ -149,7 +151,7 @@ exports.parseFilter = function(text)

* @param {string} text

* @return {ParsedFilters}

-exports.parseFilters = function(text)

+exports.parseFilters = text =>

{

let lines = text.split("\n");

let filters = [];