Issue 3692 - Add base ESLint configuration

eslint-config-eyeo/index.js

+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-2017 Eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+/* eslint-env commonjs */
+
+"use strict";
+
+module.exports = {
+  extends: "eslint:recommended",
+  env: {
+    es6: true
+  },
+  rules: {
+    "array-bracket-spacing": "error",
+    "arrow-spacing": "error",
+    "block-scoped-var": "error",
+    "block-spacing": "error",
+    "brace-style": ["error", "allman", {allowSingleLine: true}],
+    camelcase: ["error", {properties: "never"}],

[Sebastian Noack, 2017/02/10 18:04:31]

It may be against the ESLint configuration we define here, but it certainly
looks weird to omit the quotes for the rules that don't have a dash in their
name, while putting the vast majority of rules in quotes here.

[kzar, 2017/02/10 19:10:45]

Yea I agree. I think this is kind of a special case so I've changed quote-props
to "always" for this file.

[Sebastian Noack, 2017/02/12 20:53:11]

IOn 2017/02/10 19:10:45, kzar wrote:
It seems the quote-props rule has the consistent-as-needed option to target this
very case. So that if some properties need to be quoted, all are required to be
quoted for consistency. The only reservation I'd have is that with just
as-needed, I spotted cases where plain objects were misused, and a Map object
would be more appropriate. On the other hand, this file isn't an exception in
that sense, but we merely have a requirement by an external library (ESLint
requires it to be an object). Considering that (and that we won't catch all
inappropriate use of plain objects that way, and that we might have to deal with
external APIs more often), I think we should rather use consistent-as-needed.

[kzar, 2017/02/13 06:02:57]

Done.

+    "comma-dangle": "error",
+    "comma-spacing": "error",
+    "comma-style": "error",
+    "computed-property-spacing": "error",
+    curly: ["error", "multi-or-nest", "consistent"],
+    "eol-last": "error",
+    "func-call-spacing": "error",
+    indent: ["error", 2, {SwitchCase: 1, ArrayExpression: "first"}],
+    "key-spacing": "error",
+    "keyword-spacing": "error",
+    "linebreak-style": "error",
+    "lines-around-directive": "error",
+    "max-len": ["error", 80, {ignoreUrls: true}],
+    "new-parens": "error",
+    "no-array-constructor": "error",
+    "no-caller": "error",
+    "no-case-declarations": "off",
+    "no-catch-shadow": "error",
+    "no-cond-assign": "off",
+    "no-console": ["error", {allow: ["warn", "error", "trace"]}],
+    "no-control-regex": "off",
+    "no-else-return": "error",
+    "no-eval": "error",
+    "no-extra-bind": "error",
+    "no-extra-label": "error",
+    "no-implied-eval": "error",
+    "no-labels": "error",
+    "no-lone-blocks": "error",
+    "no-lonely-if": "error",
+    "no-multi-spaces": "error",
+    "no-new-func": "error",
+    "no-new-object": "error",
+    "no-proto": "error",
+    "no-self-compare": "error",
+    "no-shadow": "error",
+    "no-trailing-spaces": "error",
+    "no-unneeded-ternary": "error",
+    "no-unused-vars": "off",
+    "no-useless-computed-key": "error",
+    "no-useless-concat": "error",
+    "no-useless-escape": "error",
+    "no-useless-return": "error",
+    "no-var": "error",
+    "no-warning-comments": "error",
+    "no-whitespace-before-property": "error",
+    "no-with": "error",
+    "object-curly-spacing": "error",
+    "object-shorthand": ["error", "always", {
+      avoidExplicitReturnArrows: true
+    }],
+    "one-var": ["error", "never"],
+    "operator-assignment": "error",
+    "operator-linebreak": "error",
+    "padded-blocks": ["error", "never"],
+    "prefer-arrow-callback": "error",
+    "prefer-destructuring": ["error", {array: false}],
+    "prefer-numeric-literals": "error",
+    "prefer-rest-params": "error",
+    "prefer-spread": "error",
+    "quote-props": ["error", "as-needed"],
+    quotes: ["error", "double", {avoidEscape: true}],
+    radix: "error",
+    "rest-spread-spacing": "error",
+    semi: "error",
+    "semi-spacing": "error",
+    "space-before-function-paren": ["error", "never"],
+    "space-in-parens": "error",
+    "space-infix-ops": "error",
+    "space-unary-ops": "error",
+    "spaced-comment": "error",
+    strict: ["error", "global"],
+    "valid-jsdoc": ["error", {
+      requireParamDescription: false,
+      requireReturn: false,
+      requireReturnDescription: false
+    }],
+    "yield-star-spacing": "error",
+    yoda: "error"
+  }
+};