Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: .gitignore
Issue
29374647
:
Issue 4814 - Adds csv log to formmail2 (Closed)
Base URL: https://hg.adblockplus.org/sitescripts
Patch Set: refactor tests to be parametrized, reducing duplication. Addressed some redundancies
Created March 22, 2017, 8:14 p.m.
Left:
Base
Patch Set 1:
Patch Set 2: adds error logging and tests
Patch Set 3:
Patch Set 4: address comments, now encodes user input to utf8
Patch Set 5:
Patch Set 6:
Patch Set 7: refactor tests to be parametrized, reducing duplication. Addressed some redundancies
Patch Set 8:
Patch Set 9:
Right:
Patch Set 1:
Patch Set 2: adds error logging and tests
Patch Set 3:
Patch Set 4: address comments, now encodes user input to utf8
Patch Set 5:
Patch Set 6:
Patch Set 7: refactor tests to be parametrized, reducing duplication. Addressed some redundancies
Patch Set 8:
Patch Set 9:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.gitignore
.hgignore
.sitescripts.example
sitescripts/formmail/test/test_formmail2.py
sitescripts/formmail/web/formmail2.py
tox.ini
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
.hgignore »
('j') |
sitescripts/formmail/test/test_formmail2.py »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 *.pyc
1 *.pyc
2 *.pyo
2 *.pyo
3 **/.cache
3 **/.cache
4 /.tox
4 /.tox
5 /.sitescripts.test
5 /.sitescripts.test
6 /.coverage
6 /.coverage
7
htmlcov/
OLD
NEW
« no previous file with comments
|
« no previous file
|
.hgignore »
('j') |
sitescripts/formmail/test/test_formmail2.py »
('J')
Edit Message
Issue 29374647: Issue 4814 - Adds csv log to formmail2 (Closed)
Created Feb. 6, 2017, 6:44 p.m. by Jon Sonesen
Modified March 23, 2017, 8:01 p.m.
Reviewers: Sebastian Noack, Vasily Kuznetsov
Base URL: https://hg.adblockplus.org/sitescripts
Comments: 113
This is Rietveld