Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: README.md

Issue 29374674: Issue 4864 - Start using ESLint for adblockpluschrome (Closed)
Patch Set: Addressed some of Sebastian's feedback, made other improvements Created Feb. 20, 2017, 10:06 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « .eslintrc.json ('k') | background.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 Adblock Plus for Chrome and Opera 1 Adblock Plus for Chrome and Opera
2 ================================= 2 =================================
3 3
4 This repository contains the platform-specific Adblock Plus source code for 4 This repository contains the platform-specific Adblock Plus source code for
5 Chrome and Opera. It can be used to build Adblock Plus for these platforms, 5 Chrome and Opera. It can be used to build Adblock Plus for these platforms,
6 generic Adblock Plus code will be extracted from other repositories 6 generic Adblock Plus code will be extracted from other repositories
7 automatically (see _dependencies_ file). 7 automatically (see _dependencies_ file).
8 8
9 Building 9 Building
10 --------- 10 ---------
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 Running the unit tests 43 Running the unit tests
44 ---------------------- 44 ----------------------
45 45
46 To verify your changes you can use the unit test suite located in the _qunit_ 46 To verify your changes you can use the unit test suite located in the _qunit_
47 directory of the repository. In order to run the unit tests go to the 47 directory of the repository. In order to run the unit tests go to the
48 extension's Options page, open the JavaScript Console and type in: 48 extension's Options page, open the JavaScript Console and type in:
49 49
50 location.href = "qunit/index.html"; 50 location.href = "qunit/index.html";
51 51
52 The unit tests will run automatically once the page loads. 52 The unit tests will run automatically once the page loads.
53
54 Linting
55 -------
56
57 You can lint the code using [ESLint](http://eslint.org).
58
59 eslint *.js lib/ qunit/ ext/ chrome/
60
61 You will need to set up ESLint and our configuration first, see
62 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo)
63 for more information.
OLDNEW
« no previous file with comments | « .eslintrc.json ('k') | background.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld