Issue 4878 - Start using ESLint for adblockpluscore

test/elemHide.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
-let {createSandbox} = require("./_common");
+const {createSandbox} = require("./_common");
 
 let ElemHide = null;
 let Filter = null;
 
 exports.setUp = function(callback)
 {
   let sandboxedRequire = createSandbox();
   (
     {ElemHide} = sandboxedRequire("../lib/elemHide"),
     {Filter} = sandboxedRequire("../lib/filterClasses")
   );
 
   callback();
 };
 
 function normalizeSelectors(selectors)
 {
   // getSelectorsForDomain is currently allowed to return duplicate selectors
   // for performance reasons, so we need to remove duplicates here.
-  return selectors.sort().filter((selector, index, selectors) =>
+  return selectors.sort().filter((selector, index, sortedSelectors) =>
   {
-    return index == 0 || selector != selectors[index -  1];
+    return index == 0 || selector != sortedSelectors[index - 1];
   });
 }
 
 function testResult(test, domain, expectedSelectors, criteria)
 {
   let normalizedExpectedSelectors = normalizeSelectors(expectedSelectors);
 
   // Test without filter keys
   test.deepEqual(
     normalizeSelectors(ElemHide.getSelectorsForDomain(domain, criteria)),
@@ skipping 155 matching lines @@
   testResult(test, "foo.com", [], ElemHide.ALL_MATCHING);
   testResult(test, "foo.com", []);
   testResult(test, "bar.com", [], ElemHide.SPECIFIC_ONLY);
   testResult(test, "bar.com", ["hello"], ElemHide.NO_UNCONDITIONAL);
   testResult(test, "bar.com", ["hello"], ElemHide.ALL_MATCHING);
   testResult(test, "bar.com", ["hello"]);
   removeFilter("foo.com#@#hello");
   testResult(test, "foo.com", [], ElemHide.SPECIFIC_ONLY);
   // Note: We don't take care to track conditional selectors which became
   //       unconditional when a filter was removed. This was too expensive.
-  //testResult(test, "foo.com", [], ElemHide.NO_UNCONDITIONAL);
+  // testResult(test, "foo.com", [], ElemHide.NO_UNCONDITIONAL);
   testResult(test, "foo.com", ["hello"], ElemHide.ALL_MATCHING);
   testResult(test, "foo.com", ["hello"]);
   testResult(test, "bar.com", [], ElemHide.SPECIFIC_ONLY);
   testResult(test, "bar.com", ["hello"], ElemHide.NO_UNCONDITIONAL);
   testResult(test, "bar.com", ["hello"], ElemHide.ALL_MATCHING);
   testResult(test, "bar.com", ["hello"]);
   removeFilter("##hello");
   testResult(test, "foo.com", []);
   testResult(test, "bar.com", []);
 
@@ skipping 17 matching lines @@
 };
 
 exports.testZeroFilterKey = function(test)
 {
   ElemHide.add(Filter.fromText("##test"));
   ElemHide.add(Filter.fromText("foo.com#@#test"));
   testResult(test, "foo.com", []);
   testResult(test, "bar.com", ["test"]);
   test.done();
 };