Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/filterNotifier.js

Issue 29375915: Issue 4878 - Start using ESLint for adblockpluscore (Closed)
Left Patch Set: Remove the arrow-parens rule Created March 9, 2017, 10:23 a.m.
Right Patch Set: Removed unused imports Created March 15, 2017, 3:11 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « lib/filterListener.js ('k') | lib/filterStorage.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 13 matching lines...) Expand all
24 24
25 const {EventEmitter} = require("events"); 25 const {EventEmitter} = require("events");
26 const {desc} = require("coreUtils"); 26 const {desc} = require("coreUtils");
27 27
28 const CATCH_ALL = "__all"; 28 const CATCH_ALL = "__all";
29 29
30 /** 30 /**
31 * @callback FilterNotifierCatchAllListener 31 * @callback FilterNotifierCatchAllListener
32 * @param {string} action 32 * @param {string} action
33 * @param {Subscription|Filter} item 33 * @param {Subscription|Filter} item
34 * @param{...*} additionalInfo 34 * @param {...*} additionalInfo
Wladimir Palant 2017/03/09 14:37:13 Nit: space before { for consistency?
kzar 2017/03/10 06:56:13 Done.
35 */ 35 */
36 36
37 /** 37 /**
38 * This class allows registering and triggering listeners for filter events. 38 * This class allows registering and triggering listeners for filter events.
39 * @class 39 * @class
40 */ 40 */
41 exports.FilterNotifier = Object.create(new EventEmitter(), desc({ 41 exports.FilterNotifier = Object.create(new EventEmitter(), desc({
42 /** 42 /**
43 * Adds a listener 43 * Adds a listener
44 * 44 *
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 * @param {*} param2 77 * @param {*} param2
78 * @param {*} param3 78 * @param {*} param3
79 * @deprecated use FilterNotifier.emit(action) 79 * @deprecated use FilterNotifier.emit(action)
80 */ 80 */
81 triggerListeners(action, item, param1, param2, param3) 81 triggerListeners(action, item, param1, param2, param3)
82 { 82 {
83 this.emit(action, item, param1, param2, param3); 83 this.emit(action, item, param1, param2, param3);
84 this.emit(CATCH_ALL, action, item, param1, param2, param3); 84 this.emit(CATCH_ALL, action, item, param1, param2, param3);
85 } 85 }
86 })); 86 }));
LEFTRIGHT

Powered by Google App Engine
This is Rietveld