Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/regexpFilters_matching.js

Issue 29375915: Issue 4878 - Start using ESLint for adblockpluscore (Closed)
Patch Set: Created Feb. 20, 2017, 10:02 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/regexpFilters_matching.js
diff --git a/test/regexpFilters_matching.js b/test/regexpFilters_matching.js
index 8017945dece3c8853665ef668be1446d22647eaa..dbe310f1becb67915923513e7f9b11457a4f811f 100644
--- a/test/regexpFilters_matching.js
+++ b/test/regexpFilters_matching.js
@@ -34,17 +34,18 @@ exports.setUp = function(callback)
+function testMatchInternal(test, text, location, contentType, docDomain, thirdParty, sitekey, expected)
+{
+ let filter = Filter.fromText(text);
+ let result = filter.matches(location, RegExpFilter.typeMap[contentType], docDomain, thirdParty, sitekey);
+ test.equal(!!result, expected, '"' + text + '".matches(' + location + ", " + contentType + ", " + docDomain + ", " + (thirdParty ? "third-party" : "first-party") + ", " + (sitekey || "no-sitekey") + ")");
+}
+
function testMatch(test, text, location, contentType, docDomain, thirdParty, sitekey, expected)
{
- function testMatch_internal(text, location, contentType, docDomain, thirdParty, sitekey, expected)
- {
- let filter = Filter.fromText(text);
- let result = filter.matches(location, RegExpFilter.typeMap[contentType], docDomain, thirdParty, sitekey);
- test.equal(!!result, expected, '"' + text + '".matches(' + location + ", " + contentType + ", " + docDomain + ", " + (thirdParty ? "third-party" : "first-party") + ", " + (sitekey || "no-sitekey") + ")");
- }
- testMatch_internal(text, location, contentType, docDomain, thirdParty, sitekey, expected);
+ testMatchInternal(test, text, location, contentType, docDomain, thirdParty, sitekey, expected);
if (!/^@@/.test(text))
- testMatch_internal("@@" + text, location, contentType, docDomain, thirdParty, sitekey, expected);
+ testMatchInternal(test, "@@" + text, location, contentType, docDomain, thirdParty, sitekey, expected);
}
exports.testBasicFilters = function(test)
« lib/filterStorage.js ('K') | « test/notification.js ('k') | test/signatures.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld