libadblockplus-android/src/org/adblockplus/libadblockplus/IsAllowedConnectionCallback.java - Issue 29379647: Issue 4948 - add possibility to not send data depending on connection properties

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android/src/org/adblockplus/libadblockplus/IsAllowedConnectionCallback.java

Issue 29379647: Issue 4948 - add possibility to not send data depending on connection properties (Closed)

Patch Set: updated to 4931 code review patch set 3 and later Created March 21, 2017, 10:28 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

« libadblockplus-android/jni/JniFilterEngine.cpp ('K') | « libadblockplus-android/src/org/adblockplus/libadblockplus/FilterEngine.java ('k') | libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: libadblockplus-android/src/org/adblockplus/libadblockplus/IsAllowedConnectionCallback.java

diff --git a/libadblockplus-android/src/org/adblockplus/libadblockplus/FilterChangeCallback.java b/libadblockplus-android/src/org/adblockplus/libadblockplus/IsAllowedConnectionCallback.java

similarity index 89%

copy from libadblockplus-android/src/org/adblockplus/libadblockplus/FilterChangeCallback.java

copy to libadblockplus-android/src/org/adblockplus/libadblockplus/IsAllowedConnectionCallback.java

index f75cc285a5e810602f489e4a643de2da2445d905..e3e6387f96d8099af12516850e2674f6790abc04 100644

--- a/libadblockplus-android/src/org/adblockplus/libadblockplus/FilterChangeCallback.java

+++ b/libadblockplus-android/src/org/adblockplus/libadblockplus/IsAllowedConnectionCallback.java

@@ -17,7 +17,7 @@

package org.adblockplus.libadblockplus;

-public abstract class FilterChangeCallback implements Disposable

+public abstract class IsAllowedConnectionCallback implements Disposable

{

private final Disposer disposer;

protected final long ptr;

@@ -28,13 +28,13 @@ public abstract class FilterChangeCallback implements Disposable

registerNatives();

}

- public FilterChangeCallback()

+ public IsAllowedConnectionCallback()

{

this.ptr = ctor(this);

this.disposer = new Disposer(this, new DisposeWrapper(this.ptr));

}

- public abstract void filterChangeCallback(String action, JsValue jsValue);

+ public abstract boolean isConnectionAllowed(String connection);

@Override

public void dispose()