No issue - change initialiser calls

test/WebRequest.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 39 matching lines @@
     mutable std::set<std::string> lastRequestHeaders;
   };
 
   template<class T>
   class WebRequestTest : public BaseJsTest
   {
   protected:
     void SetUp()
     {
       BaseJsTest::SetUp();
-      jsEngine->SetWebRequest(AdblockPlus::WebRequestPtr(new T));
-      jsEngine->SetFileSystem(AdblockPlus::FileSystemPtr(new LazyFileSystem));
+      jsEngine->SetWebRequest(AdblockPlus::WebRequestPtr(new T()));
+      jsEngine->SetFileSystem(AdblockPlus::FileSystemPtr(new LazyFileSystem()));
     }
   };
 
   typedef WebRequestTest<MockWebRequest> MockWebRequestTest;
   typedef WebRequestTest<AdblockPlus::DefaultWebRequest> DefaultWebRequestTest;
   typedef WebRequestTest<MockWebRequest> XMLHttpRequestTest;
 
   void ResetTestXHR(const AdblockPlus::JsEnginePtr& jsEngine)
   {
     jsEngine->Evaluate("\
@@ skipping 128 matching lines @@
       lastLogLevel = AdblockPlus::LogSystem::LOG_LEVEL_TRACE;
       lastMessage.clear();
     }
   };
 
   typedef std::shared_ptr<CatchLogSystem> CatchLogSystemPtr;
 }
 
 TEST_F(XMLHttpRequestTest, RequestHeaderValidation)
 {
-  auto catchLogSystem = CatchLogSystemPtr(new CatchLogSystem);
+  CatchLogSystemPtr catchLogSystem = std::make_shared<CatchLogSystem>();

[sergei, 2017/03/13 14:33:45]

with std::make_shared `auto` is preferred :)

   jsEngine->SetLogSystem(catchLogSystem);
 
   AdblockPlus::FilterEngine filterEngine(jsEngine);
   auto webRequest =
     std::static_pointer_cast<MockWebRequest>(jsEngine->GetWebRequest());
 
   ASSERT_TRUE(webRequest);
 
   const std::string msg = "Attempt to set a forbidden header was denied: ";
 
@@ skipping 60 matching lines @@
   catchLogSystem->clear();
   ResetTestXHR(jsEngine);
   jsEngine->Evaluate("\
     request.setRequestHeader('Security', 'theater');\nrequest.send();");
   EXPECT_EQ(AdblockPlus::LogSystem::LOG_LEVEL_TRACE, catchLogSystem->lastLogLevel);
   EXPECT_EQ("", catchLogSystem->lastMessage);
   WaitForVariable("result", jsEngine);
   EXPECT_FALSE(webRequest->lastRequestHeaders.cend() ==
                webRequest->lastRequestHeaders.find("Security"));
 }