.gitignore - Issue 29385633: Issue 4998 - Add .gitignore

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: .gitignore

Issue 29385633: Issue 4998 - Add .gitignore (Closed)

Patch Set: Created March 16, 2017, 8:43 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 syntax: glob	1 syntax: glob
Felix Dahlke 2017/03/16 10:49:18 Isn't that the default behaviour in Git? Does it e Isn't that the default behaviour in Git? Does it even support this syntax directive? anton 2017/03/16 11:06:43 The file was created by just copy/renaming from .h Show quoted text On 2017/03/16 10:49:18, Felix Dahlke wrote: > Isn't that the default behaviour in Git? Does it even support this syntax > directive? The file was created by just copy/renaming from .hgignore. It's Git default behaviour so we don't need it (and yes - Git does not support `syntax` - https://git-scm.com/docs/gitignore). BTW - same here https://codereview.adblockplus.org/29384850/diff/29384851/.gitignore Felix Dahlke 2017/03/16 11:08:36 I'd still say let's leave it out (didn't catch it Show quoted text On 2017/03/16 11:06:43, anton wrote: > On 2017/03/16 10:49:18, Felix Dahlke wrote: > > Isn't that the default behaviour in Git? Does it even support this syntax > > directive? > > The file was created by just copy/renaming from .hgignore. > It's Git default behaviour so we don't need it (and yes - Git does not support > `syntax` - https://git-scm.com/docs/gitignore). > BTW - same here > https://codereview.adblockplus.org/29384850/diff/29384851/.gitignore I'd still say let's leave it out (didn't catch it in that other review). (See the .gitignore files in our other repos such as adblockplus and adblockpluschrome)
2	2

3 crowdin.yaml	3 crowdin.yaml

4 */libs/armeabi	4 */libs/armeabi

5 **/libs/x86	5 **/libs/x86

6 **/bin	6 **/bin

7 **/obj	7 **/obj

8 **/gen	8 **/gen

9 **/build	9 **/build

10 **/local.properties	10 **/local.properties

11 **/ant.properties	11 **/ant.properties

12 **/buildtools	12 **/buildtools

13 **/target	13 **/target

14 .idea	14 .idea

15 *.iml	15 *.iml

16 upload.py	16 upload.py

17 .DS_Store	17 .DS_Store

18 .*	18 .*

19 !.gitignore	19 !.gitignore

20 !.hgignore	20 !.hgignore

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »