Issue 5005 - Always show the menu icon

mobile/android/base/util/HardwareUtils.java

 /* -*- Mode: Java; c-basic-offset: 4; tab-width: 20; indent-tabs-mode: nil; -*-
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 package org.mozilla.gecko.util;
 
 import org.mozilla.gecko.SysInfo;
 
 import android.content.Context;
@@ skipping 72 matching lines @@
 
     public static boolean isSmallTablet() {
         return sIsSmallTablet;
     }
 
     public static boolean isTelevision() {
         return sIsTelevision;
     }
 
     public static boolean hasMenuButton() {
-        return sHasMenuButton;
+        // Forcing behavior idependently of the presence of a hardware menu button

[anton, 2017/03/17 06:53:11]

LGTM though i'd suggest to explain a bit what behavior is meant is showing the
icons is the only change

[Felix Dahlke, 2017/03/27 15:46:57]

I figure when looking at #5005 that becomes apparent.

I do mind the typo though: "idependently" :)

+        // See https://issues.adblockplus.org/ticket/5005
+        return false;
     }
 
     public static int getMemSize() {
         return SysInfo.getMemSize();
     }
 
     public static boolean isLowMemoryPlatform() {
         final int memSize = getMemSize();
 
         // Fallback to false if we fail to read meminfo
         // for some reason.
         if (memSize == 0) {
             Log.w(LOGTAG, "Could not compute system memory. Falling back to isLowMemoryPlatform = false.");
             return false;
         }
 
         return memSize < LOW_MEMORY_THRESHOLD_MB;
     }
 }