Issue 5009 - Ignore frame redirections within popups

lib/popupBlocker.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 56 matching lines @@
 
   logRequest(
     popup.sourcePage, urlString, "POPUP",
     documentHost, thirdParty, null,
     specificOnly, filter
   );
 }
 
 function onPopupURLChanged(details)
 {
+  // We only care about redirections within the top-level frame.
+  if (details.frameId != 0)
+    return;
+
   let popup = loadingPopups[details.tabId];
   if (popup)
   {
     popup.url = details.url;
     if (popup.sourceFrame)
       checkPotentialPopup(details.tabId, popup);
   }
 }
 
 function onCompleted(details)
@@ skipping 29 matching lines @@
   if (checkWhitelisted(popup.sourcePage, frame))
   {
     forgetPopup(tabId);
   }
   else
   {
     popup.sourceFrame = frame;
     checkPotentialPopup(tabId, popup);
   }
 });