Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/popupBlocker.js

Issue 29386580: Issue 5009 - Ignore frame redirections within popups (Closed)
Patch Set: Created March 17, 2017, 9:12 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/popupBlocker.js
diff --git a/lib/popupBlocker.js b/lib/popupBlocker.js
index 55cb4e594da873c5a5bb24e62dea09989d3f63d8..e57ad1636e5e7655a60efb80409ab598aefe1738 100644
--- a/lib/popupBlocker.js
+++ b/lib/popupBlocker.js
@@ -74,6 +74,10 @@ function checkPotentialPopup(tabId, popup)
function onPopupURLChanged(details)
{
+ // We only care about redirections within the top-level frame.
+ if (details.frameId != 0)
+ return;
+
let popup = loadingPopups[details.tabId];
if (popup)
{
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld