metadata.chrome - Issue 29394585: Issue 5027 - Use updated webRequest API for WebSocket blocking

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: metadata.chrome

Issue 29394585: Issue 5027 - Use updated webRequest API for WebSocket blocking (Closed)

Patch Set: fixed logic at websocket wrapper Created March 27, 2017, 12:36 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 [default]	1 [default]

2 inherit = metadata.common	2 inherit = metadata.common

3	3

4 [general]	4 [general]

5 basename = adblockpluschrome	5 basename = adblockpluschrome

6 permissions = tabs	6 permissions = tabs

7 http:///	7 http:///

8 https:///	8 https:///

	9 ws:///
	kzar 2017/03/28 05:38:13 I wonder if adding new permissions is OK, I don't I wonder if adding new permissions is OK, I don't know how it works. Is the user prompted about it, or is the extension disabled, or does something else happen? Sebastian Noack 2017/03/28 05:58:19 There are only certain permissions changes, that n Show quoted text On 2017/03/28 05:38:13, kzar wrote: > I wonder if adding new permissions is OK, I don't know how it works. Is the user > prompted about it, or is the extension disabled, or does something else happen? There are only certain permissions changes, that needs to be confirmed by the user. According to the documentation, this doesn't seem to be any of them: https://developer.chrome.com/extensions/permission_warnings But we probably should double check, therefore however, we first need to land this change, and then watch what's going to happen when the devbuild is updated from the Chrome Web Store.
	10 wss:///

9 contextMenus	11 contextMenus

10 webRequest	12 webRequest

11 webRequestBlocking	13 webRequestBlocking

12 webNavigation	14 webNavigation

13 storage	15 storage

14 unlimitedStorage	16 unlimitedStorage

15 notifications	17 notifications

16 options = options.html	18 options = options.html

17 devtools = devtools.html	19 devtools = devtools.html

18 browserAction = icons/abp-16.png icons/abp-19.png icons/abp-20.png icons/abp-32. png icons/abp-38.png icons/abp-40.png popup.html	20 browserAction = icons/abp-16.png icons/abp-19.png icons/abp-20.png icons/abp-32. png icons/abp-38.png icons/abp-40.png popup.html

(...skipping 36 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
55 devtools.js = chrome/devtools.js	57 devtools.js = chrome/devtools.js

56 devtools-panel.html = adblockplusui/devtools-panel.html	58 devtools-panel.html = adblockplusui/devtools-panel.html

57 devtools-panel.js = adblockplusui/devtools-panel.js	59 devtools-panel.js = adblockplusui/devtools-panel.js

58 skin/devtools-panel.css = adblockplusui/skin/devtools-panel.css	60 skin/devtools-panel.css = adblockplusui/skin/devtools-panel.css

59 managed-storage-schema.json = chrome/managed-storage-schema.json	61 managed-storage-schema.json = chrome/managed-storage-schema.json

60	62

61 [convert_js]	63 [convert_js]

62 lib/adblockplus.js += lib/devtools.js lib/popupBlocker.js lib/uninstall.js lib/c sp.js	64 lib/adblockplus.js += lib/devtools.js lib/popupBlocker.js lib/uninstall.js lib/c sp.js

63 ext/common.js += chrome/ext/common.js	65 ext/common.js += chrome/ext/common.js

64 ext/background.js += chrome/ext/background.js	66 ext/background.js += chrome/ext/background.js

OLD	NEW

« lib/requestBlocker.js ('K') | « lib/requestBlocker.js ('k') | no next file » | no next file with comments »