Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/filterListener.js

Issue 29397663: Noissue - Fix a break when loading adblockpluscore into Chrome extension (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Added eslint hints Created March 29, 2017, 9:34 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/filterStorage.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/filterListener.js
===================================================================
--- a/lib/filterListener.js
+++ b/lib/filterListener.js
@@ -1,8 +1,9 @@
+/* globals XPCOM, XPCOMUtils, Services */
/*
* This file is part of Adblock Plus <https://adblockplus.org/>,
* Copyright (C) 2006-2017 eyeo GmbH
*
* Adblock Plus is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 3 as
* published by the Free Software Foundation.
*
@@ -17,18 +18,18 @@
"use strict";
/**
* @fileOverview Component synchronizing filter storage with Matcher
* instances and ElemHide.
*/
-const {Services} = Cu.import("resource://gre/modules/Services.jsm", {});
-const {XPCOMUtils} = Cu.import("resource://gre/modules/XPCOMUtils.jsm", {});
+Cu.import("resource://gre/modules/XPCOMUtils.jsm");
kzar 2017/03/30 05:30:07 Nit: It seems you changed the order of these impor
+Cu.import("resource://gre/modules/Services.jsm");
const {FilterStorage} = require("filterStorage");
const {FilterNotifier} = require("filterNotifier");
const {ElemHide} = require("elemHide");
const {ElemHideEmulation} = require("elemHideEmulation");
const {defaultMatcher} = require("matcher");
const {ActiveFilter, RegExpFilter,
ElemHideBase, ElemHideEmulationFilter} = require("filterClasses");
« no previous file with comments | « no previous file | lib/filterStorage.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld