dependencies - Issue 29398651: Issue 5061 - Update adblockpluscore dependency to 3bdddf0e8343

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: dependencies

Issue 29398651: Issue 5061 - Update adblockpluscore dependency to 3bdddf0e8343 (Closed)

Left Patch Set: Created March 30, 2017, 7:33 a.m.

Right Patch Set: Update dependency further Created March 30, 2017, 1:55 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/	1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/

2 _self = buildtools/ensure_dependencies.py	2 _self = buildtools/ensure_dependencies.py

3 buildtools = buildtools hg:1b59fbf12b07 git:6a2fb97	3 buildtools = buildtools hg:1b59fbf12b07 git:6a2fb97

4 adblockplus = adblockplus hg:c8ec667756d3 git:9a42447	4 adblockplus = adblockplus hg:c8ec667756d3 git:9a42447

5 adblockpluscore = adblockpluscore hg:68a4dc4e79e8 git:2574147	5 adblockpluscore = adblockpluscore hg:3bdddf0e8343 git:bb21628
Sebastian Noack 2017/03/30 08:02:30 While there is a separate issue for this dependenc While there is a separate issue for this dependency update now, mind updating to the latest version of adblockpluscore, while on it? Sebastian Noack 2017/03/30 10:54:34 The problem there was that the dependency was upda Show quoted text On 2017/03/30 09:21:08, kzar wrote: > On 2017/03/30 08:02:30, Sebastian Noack wrote: > > While there is a separate issue for this dependency update now, mind > > updating to the latest version of adblockpluscore, while on it? > > I would rather not if that's OK, since doing something similar bit me on the > arse recently with the "Hide targeted..." notifications. The problem there was that the dependency was updated along changes that relied on an upstream change but nobody cared about the other changes pulled in. The solution therefore is not to have a separate dependency update for each upstream change, but to make sure that all upstream changes get considered when updating the dependency. Though, when there is no separate issue for the dependency update, I'd agree that some upstream changes are potentially unrelated. But since there is a separate issue for this dependency update, there is no reason to not have it pull in all upstream changes, while on it. Just make sure that the issue description covers all relevant changes pulled in, and adapt any integration code where necessary. It's actually less risky this way, because if done properly, the next dependency update will be more safe, while otherwise the risk is just carried over to future dependency updates. kzar 2017/03/30 13:56:32 Done. Show quoted text On 2017/03/30 10:54:34, Sebastian Noack wrote: > On 2017/03/30 09:21:08, kzar wrote: > > On 2017/03/30 08:02:30, Sebastian Noack wrote: > > > While there is a separate issue for this dependency update now, mind > > > updating to the latest version of adblockpluscore, while on it? > > > > I would rather not if that's OK, since doing something similar bit me on the > > arse recently with the "Hide targeted..." notifications. > > The problem there was that the dependency was updated along changes that relied > on an upstream change but nobody cared about the other changes pulled in. The > solution therefore is not to have a separate dependency update for each upstream > change, but to make sure that all upstream changes get considered when updating > the dependency. Though, when there is no separate issue for the dependency > update, I'd agree that some upstream changes are potentially unrelated. But > since there is a separate issue for this dependency update, there is no reason > to not have it pull in all upstream changes, while on it. Just make sure that > the issue description covers all relevant changes pulled in, and adapt any > integration code where necessary. It's actually less risky this way, because if > done properly, the next dependency update will be more safe, while otherwise the > risk is just carried over to future dependency updates. Done.
6 adblockplusui = adblockplusui hg:8ceaabb9c639 git:6222fd2	6 adblockplusui = adblockplusui hg:8ceaabb9c639 git:6222fd2

LEFT	RIGHT