Issue 5061 - Update adblockpluscore dependency to 3bdddf0e8343

dependencies

Index: dependencies
diff --git a/dependencies b/dependencies
index edae732aac38658406654f00b511ddb24fa5f48b..5ed96bc1e39a2c4036774bfc26d3d7a13a050893 100644
--- a/dependencies
+++ b/dependencies
@@ -2,5 +2,5 @@ _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/
 _self = buildtools/ensure_dependencies.py
 buildtools = buildtools hg:1b59fbf12b07 git:6a2fb97
 adblockplus = adblockplus hg:c8ec667756d3 git:9a42447
-adblockpluscore = adblockpluscore hg:c7ae7532578a git:50ebfcf
+adblockpluscore = adblockpluscore hg:68a4dc4e79e8 git:2574147

[Sebastian Noack, 2017/03/30 08:02:30]

While there is a separate issue for this dependency update now, mind updating to
the latest version of adblockpluscore, while on it?

[Sebastian Noack, 2017/03/30 10:54:34]

The problem there was that the dependency was updated along changes that relied
on an upstream change but nobody cared about the other changes pulled in. The
solution therefore is not to have a separate dependency update for each upstream
change, but to make sure that all upstream changes get considered when updating
the dependency. Though, when there is no separate issue for the dependency
update, I'd agree that some upstream changes are potentially unrelated. But
since there is a separate issue for this dependency update, there is no reason
to not have it pull in all upstream changes, while on it. Just make sure that
the issue description covers all relevant changes pulled in, and adapt any
integration code where necessary. It's actually less risky this way, because if
done properly, the next dependency update will be more safe, while otherwise the
risk is just carried over to future dependency updates.

[kzar, 2017/03/30 13:56:32]

Done.

 adblockplusui = adblockplusui hg:8ceaabb9c639 git:6222fd2