Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: compiled/FilterNotifier.h

Issue 29398669: Issue 5063 - [emscripten] Make FilterNotifier calls more efficient (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore
Left Patch Set: Rebased and made the code deal with 64-bit properties Created April 7, 2017, 7:16 a.m.
Right Patch Set: Addressed comments Created April 20, 2017, 8 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | compiled/FilterNotifier.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 #pragma once 18 #pragma once
19 19
20 #include <cstdio> 20 #include <cstdio>
21 21
22 #include "String.h" 22 #include "String.h"
23
24 class Filter;
25 class Subscription;
23 26
24 namespace FilterNotifier 27 namespace FilterNotifier
25 { 28 {
26 enum class Topic 29 enum class Topic
27 { 30 {
28 NONE, 31 NONE,
29 FILTER_DISABLED, 32 FILTER_DISABLED,
30 FILTER_HITCOUNT, 33 FILTER_HITCOUNT,
31 FILTER_LASTHIT, 34 FILTER_LASTHIT,
32 SUBSCRIPTION_TITLE, 35 SUBSCRIPTION_TITLE,
(...skipping 17 matching lines...) Expand all
50 printf(" [%i, 'subscription.disabled'],\n", Topic::SUBSCRIPTION_DISABLED); 53 printf(" [%i, 'subscription.disabled'],\n", Topic::SUBSCRIPTION_DISABLED);
51 printf(" [%i, 'subscription.fixedTitle'],\n", Topic::SUBSCRIPTION_FIXEDTITL E); 54 printf(" [%i, 'subscription.fixedTitle'],\n", Topic::SUBSCRIPTION_FIXEDTITL E);
52 printf(" [%i, 'subscription.homepage'],\n", Topic::SUBSCRIPTION_HOMEPAGE); 55 printf(" [%i, 'subscription.homepage'],\n", Topic::SUBSCRIPTION_HOMEPAGE);
53 printf(" [%i, 'subscription.lastCheck'],\n", Topic::SUBSCRIPTION_LASTCHECK) ; 56 printf(" [%i, 'subscription.lastCheck'],\n", Topic::SUBSCRIPTION_LASTCHECK) ;
54 printf(" [%i, 'subscription.lastDownload'],\n", Topic::SUBSCRIPTION_LASTDOW NLOAD); 57 printf(" [%i, 'subscription.lastDownload'],\n", Topic::SUBSCRIPTION_LASTDOW NLOAD);
55 printf(" [%i, 'subscription.downloadStatus'],\n", Topic::SUBSCRIPTION_DOWNL OADSTATUS); 58 printf(" [%i, 'subscription.downloadStatus'],\n", Topic::SUBSCRIPTION_DOWNL OADSTATUS);
56 printf(" [%i, 'subscription.errors'],\n", Topic::SUBSCRIPTION_ERRORS); 59 printf(" [%i, 'subscription.errors'],\n", Topic::SUBSCRIPTION_ERRORS);
57 printf("]);"); 60 printf("]);");
58 } 61 }
59 62
60 void PropertyChange(Topic topic, void* object, bool newValue, bool oldValue); 63 void FilterChange(Topic topic, Filter* filter);
61 void PropertyChange(Topic topic, void* object, int newValue, int oldValue); 64 void SubscriptionChange(Topic topic, Subscription* subscription);
62 void PropertyChange(Topic topic, void* object, unsigned int newValue,
63 unsigned int oldValue);
64 void PropertyChange(Topic topic, void* object, uint64_t newValue,
65 uint64_t oldValue);
66 void PropertyChange(Topic topic, void* object, const String& newValue,
67 const String& oldValue);
68 } 65 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld