Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: compiled/bindings.cpp

Issue 29398669: Issue 5063 - [emscripten] Make FilterNotifier calls more efficient (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore
Patch Set: Removed newValue and oldValue parameters Created April 15, 2017, 3:05 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiled/bindings.cpp
===================================================================
--- a/compiled/bindings.cpp
+++ b/compiled/bindings.cpp
@@ -25,16 +25,17 @@
#include "filter/WhitelistFilter.h"
#include "filter/ElemHideBase.h"
#include "filter/ElemHideFilter.h"
#include "filter/ElemHideException.h"
#include "filter/ElemHideEmulationFilter.h"
#include "subscription/Subscription.h"
#include "subscription/DownloadableSubscription.h"
#include "subscription/UserDefinedSubscription.h"
+#include "FilterNotifier.h"
EMSCRIPTEN_BINDINGS
{
class_<Filter>("Filter")
.property("text", &Filter::GetText)
.function("serialize", &Filter::Serialize)
.class_function("fromText", &Filter::FromText)
.subclass_differentiator(&Filter::mType, {
@@ -118,9 +119,11 @@ EMSCRIPTEN_BINDINGS
.property("lastDownload", &DownloadableSubscription::GetLastDownload, &DownloadableSubscription::SetLastDownload)
.property("downloadStatus", &DownloadableSubscription::GetDownloadStatus, &DownloadableSubscription::SetDownloadStatus)
.property("lastSuccess", &DownloadableSubscription::GetLastSuccess, &DownloadableSubscription::SetLastSuccess)
.property("errors", &DownloadableSubscription::GetErrorCount, &DownloadableSubscription::SetErrorCount)
.property("version", &DownloadableSubscription::GetDataRevision, &DownloadableSubscription::SetDataRevision)
.property("requiredVersion", &DownloadableSubscription::GetRequiredVersion, &DownloadableSubscription::SetRequiredVersion)
.property("downloadCount", &DownloadableSubscription::GetDownloadCount, &DownloadableSubscription::SetDownloadCount)
.function("serialize", &DownloadableSubscription::Serialize);
+
+ custom_generator(&FilterNotifier::GenerateCustomBindings);
}

Powered by Google App Engine
This is Rietveld