dependencies - Issue 29399577: Issue 5077 - Update buildtools dependency to 1ed9c0c32f78

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: dependencies

Issue 29399577: Issue 5077 - Update buildtools dependency to 1ed9c0c32f78 (Closed)

Left Patch Set: Created March 31, 2017, 6:01 a.m.

Right Patch Set: Update revision Created April 3, 2017, 7:35 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/	1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/

2 _self = buildtools/ensure_dependencies.py	2 _self = buildtools/ensure_dependencies.py

3 buildtools = buildtools git:5060-modules	3 buildtools = buildtools hg:1ed9c0c32f78 git:6966639
kzar 2017/03/31 06:02:54 I will update this with the proper revision once # I will update this with the proper revision once #5060 lands. Sebastian Noack 2017/04/03 06:07:25 This can be done now, #5060 has landed. Show quoted text On 2017/03/31 06:02:54, kzar wrote: > I will update this with the proper revision once #5060 lands. This can be done now, #5060 has landed. kzar 2017/04/03 06:21:59 No, it's also blocked by #5078. Before you ask why Show quoted text On 2017/04/03 06:07:25, Sebastian Noack wrote: > On 2017/03/31 06:02:54, kzar wrote: > > I will update this with the proper revision once #5060 lands. > > This can be done now, #5060 has landed. No, it's also blocked by #5078. Before you ask why see my working branch https://github.com/adblockplus/adblockpluschrome/compare/master...kzar:5080-c... Sebastian Noack 2017/04/03 10:14:27 For reference, #5078 got rejected in favor of usin Show quoted text On 2017/04/03 06:21:59, kzar wrote: > On 2017/04/03 06:07:25, Sebastian Noack wrote: > > On 2017/03/31 06:02:54, kzar wrote: > > > I will update this with the proper revision once #5060 lands. > > > > This can be done now, #5060 has landed. > > No, it's also blocked by #5078. Before you ask why see my working branch > https://github.com/adblockplus/adblockpluschrome/compare/master...kzar:5080-c... For reference, #5078 got rejected in favor of using modules consistently. So this comment is no longer relevant, and the dependency's revision got updated accordingly. So LGTM.
4 adblockplus = adblockplus hg:c8ec667756d3 git:9a42447	4 adblockplus = adblockplus hg:c8ec667756d3 git:9a42447

5 adblockpluscore = adblockpluscore hg:3bdddf0e8343 git:bb21628	5 adblockpluscore = adblockpluscore hg:3bdddf0e8343 git:bb21628

6 adblockplusui = adblockplusui hg:8ceaabb9c639 git:6222fd2	6 adblockplusui = adblockplusui hg:8ceaabb9c639 git:6222fd2

LEFT	RIGHT