Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/AppInfoJsObject.cpp

Issue 29409580: Issue 5013 - Make parameter const ref when applicable. (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Created April 11, 2017, 1:58 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/AppInfoJsObject.cpp
===================================================================
--- a/src/AppInfoJsObject.cpp
+++ b/src/AppInfoJsObject.cpp
@@ -18,18 +18,18 @@
#include <AdblockPlus/AppInfo.h>
#include <AdblockPlus/JsValue.h>
#include "AppInfoJsObject.h"
#include "Utils.h"
using namespace AdblockPlus;
-JsValuePtr AppInfoJsObject::Setup(JsEnginePtr jsEngine, const AppInfo& appInfo,
- JsValuePtr obj)
+JsValuePtr AppInfoJsObject::Setup(const JsEnginePtr& jsEngine, const AppInfo& appInfo,
+ const JsValuePtr& obj)
{
obj->SetProperty("version", appInfo.version);
obj->SetProperty("name", appInfo.name);
obj->SetProperty("application", appInfo.application);
obj->SetProperty("applicationVersion", appInfo.applicationVersion);
obj->SetProperty("locale", appInfo.locale);
obj->SetProperty("developmentBuild", appInfo.developmentBuild);
return obj;

Powered by Google App Engine
This is Rietveld